Subject: pkg/22950: don't use base-OS libz with archivers/unzip
To: None <gnats-bugs@gnats.netbsd.org>
From: Greg A. Woods <woods@weird.com>
List: netbsd-bugs
Date: 09/25/2003 14:31:33
>Number:         22950
>Category:       pkg
>Synopsis:       don't use base-OS libz with archivers/unzip
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Thu Sep 25 18:32:00 UTC 2003
>Closed-Date:
>Last-Modified:
>Originator:     Greg A. Woods
>Release:        2003/09/18
>Organization:
Planix, Inc.; Toronto, Ontario; Canada
>Environment:
System: NetBSD
>Description:

	I think it's a really bad idea to use the base-OS libz with the
	unzip package, especially if the reason for updating unzip has
	something to do with security issues and where some of the fixes
	may well be in libz.

>How-To-Repeat:

>Fix:

Index: archivers/unzip/Makefile
===================================================================
RCS file: /cvs/master/m-NetBSD/main/pkgsrc/archivers/unzip/Makefile,v
retrieving revision 1.43
diff -c -r1.43 Makefile
*** archivers/unzip/Makefile	5 Sep 2003 19:00:58 -0000	1.43
--- archivers/unzip/Makefile	19 Sep 2003 01:00:34 -0000
***************
*** 23,33 ****
  .include "../../mk/bsd.prefs.mk"
  
  MAKEFILE=	unix/Makefile
! ALL_TARGET=	generic_zlib unzipsfx
  .if ${OPSYS:M*BSD} != "" || ${OPSYS} == "Darwin"
! MAKE_FLAGS=	CF="${CFLAGS} -I. -DBSD -DUNIX -Dunix -DUSE_UNSHRINK" LF2="-lz ${_STRIPFLAG_CC} ${LDFLAGS}"
  .else
! MAKE_FLAGS=	CF="${CFLAGS} -I. -DUNIX -Dunix -DUSE_UNSHRINK" LF2="-lz ${_STRIPFLAG_CC} ${LDFLAGS}"
  .endif
  
  do-install:
--- 23,33 ----
  .include "../../mk/bsd.prefs.mk"
  
  MAKEFILE=	unix/Makefile
! ALL_TARGET=	generic unzipsfx
  .if ${OPSYS:M*BSD} != "" || ${OPSYS} == "Darwin"
! MAKE_FLAGS=	CF="${CFLAGS} -I. -DBSD -DUNIX -Dunix -DUSE_UNSHRINK" LF2="${_STRIPFLAG_CC} ${LDFLAGS}"
  .else
! MAKE_FLAGS=	CF="${CFLAGS} -I. -DUNIX -Dunix -DUSE_UNSHRINK" LF2="${_STRIPFLAG_CC} ${LDFLAGS}"
  .endif
  
  do-install:
***************
*** 40,44 ****
  	cd ${WRKSRC} && ${INSTALL_DATA} BUGS COPYING.OLD LICENSE README WHERE \
  		${PREFIX}/share/doc/unzip
  
- .include "../../devel/zlib/buildlink2.mk"
  .include "../../mk/bsd.pkg.mk"
--- 40,43 ----
>Release-Note:
>Audit-Trail:
>Unformatted: