>Number:         22872
>Category:       pkg
>Synopsis:       macfork needs string.h for strcmp() on some systems
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Sep 20 14:50:00 UTC 2003
>Closed-Date:
>Last-Modified:
>Originator:     Jonathan Perkin
>Release:        N/A
>Organization:
British Broadcasting Corporation
>Environment:
SunOS build1 5.9 Generic_112233-01 sun4u sparc SUNW,UltraSPARC-IIi-cEngine
>Description:
converters/macfork fails on at least SunOS, which requires string.h
for strcmp().
>How-To-Repeat:
http://www.perkin.org.uk/projects/netbsd/macfork.diff

===> Building for macfork-1.0
g++ -g -Wall -I- -I.   -c -o Resource.o Resource.cc
Resource.cc: In member function `Int ResourceFile::GetTypeNumber(const Char*)':
Resource.cc:76: error: `strcmp' undeclared (first use this function)
Resource.cc:76: error: (Each undeclared identifier is reported only once for
   each function it appears in.)
gmake: *** [Resource.o] Error 1
*** Error code 2
>Fix:
Index: distinfo
===================================================================
RCS file: /cvsroot/pkgsrc/converters/macfork/distinfo,v
retrieving revision 1.1.1.1
diff -u -r1.1.1.1 distinfo
--- distinfo    2001/09/26 05:36:18     1.1.1.1
+++ distinfo    2003/09/20 14:46:14
@@ -2,4 +2,4 @@
 
 SHA1 (macfork-1.0.tar.gz) = 86cbf8a7a3c65bd168f40ef9ab1e1a73161abdd0
 Size (macfork-1.0.tar.gz) = 15451 bytes
-SHA1 (patch-aa) = 68721ccd60464527b442b5bab1397cc1b4e26ee8
+SHA1 (patch-aa) = 1adb9922d5b2856a964d30a1514fbdcb11621474
Index: patches/patch-aa
===================================================================
RCS file: /cvsroot/pkgsrc/converters/macfork/patches/patch-aa,v
retrieving revision 1.1.1.1
diff -u -r1.1.1.1 patch-aa
--- patches/patch-aa    2001/09/26 05:36:18     1.1.1.1
+++ patches/patch-aa    2003/09/20 14:46:14
@@ -1,11 +1,12 @@
 $NetBSD: patch-aa,v 1.1.1.1 2001/09/26 05:36:18 jlam Exp $
 
---- Resource.cc~       Tue Aug 31 19:10:19 1999
-+++ Resource.cc        Mon Sep  3 21:12:01 2001
-@@ -9,6 +9,8 @@
+--- Resource.cc.orig   Tue Aug 31 18:10:19 1999
++++ Resource.cc        Sat Sep 20 15:41:58 2003
+@@ -9,6 +9,9 @@
  */
  
  #include "Resource.h"
++#include <string.h>
 +#include <sys/types.h>
 +#include <sys/socket.h>
  #include <netinet/in.h>
>Release-Note:
>Audit-Trail:
>Unformatted: