>Number:         22855
>Category:       pkg
>Synopsis:       Fix benchmarks/bytebench on SunOS
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Sep 19 13:58:00 UTC 2003
>Closed-Date:
>Last-Modified:
>Originator:     Jonathan Perkin
>Release:        N/A
>Organization:
British Broadcasting Corporation
>Environment:
SunOS build1 5.9 Generic_112233-01 sun4u sparc SUNW,UltraSPARC-IIi-cEngine
>Description:
Solaris' limits.h doesn't expose PATH_MAX (as provided in patch-af) when
compiling with -ansi.  This breaks the build.

Fix by removing package-specific CFLAGS (cleans up redundant -DTIME too).
>How-To-Repeat:
/home/jonp/pkg/gcc-3.3/bin/gcc -o ./pgms/execl -O -DTIME -DTIME -Wall -pedantic -ansi -O2 -fomit-frame-pointer -fforce-addr -fforce-mem -ffast-math -Wall ./src/execl.c
In file included from src/execl.c:33:
src/big.c: In function `dummy':
src/big.c:172: warning: int format, pid_t arg (arg 3)
src/big.c: In function `wrapup':
src/big.c:425: warning: implicit declaration of function `kill'
src/execl.c: In function `main':
src/execl.c:49: error: `PATH_MAX' undeclared (first use in this function)
src/execl.c:49: error: (Each undeclared identifier is reported only once
src/execl.c:49: error: for each function it appears in.)
src/execl.c:49: warning: unused variable `path_str'
*** Error code 1
>Fix:
http://www.perkin.org.uk/projects/netbsd/bytebench.diff

Index: distinfo
===================================================================
RCS file: /cvsroot/pkgsrc/benchmarks/bytebench/distinfo,v
retrieving revision 1.5
diff -u -r1.5 distinfo
--- distinfo    2003/04/26 05:18:00     1.5
+++ distinfo    2003/09/19 13:53:38
@@ -3,7 +3,7 @@
 SHA1 (unixbench-4.1.0.tgz) = 0a43d9cf08869c0f81bde4647be6bcf76c064248
 Size (unixbench-4.1.0.tgz) = 63075 bytes
 SHA1 (patch-aa) = e99170aaa9100486ef4e62387a0795dd4372f157
-SHA1 (patch-ab) = b018ad36a3a72b16bb29e8049a7bfe172888b5b8
+SHA1 (patch-ab) = aa5cd9d5a423f9def2a3085072504624cd51c1bd
 SHA1 (patch-ac) = ebfb09da84c96f8c6f48293c65a74dcf8a43cff5
 SHA1 (patch-ad) = 3a1b788d9fa51fc168d59d8c87b1f476df2d5f41
 SHA1 (patch-ae) = fbbce3deed7f0421034c1d57b66b1967ad8bddf1
Index: patches/patch-ab
===================================================================
RCS file: /cvsroot/pkgsrc/benchmarks/bytebench/patches/patch-ab,v
retrieving revision 1.2
diff -u -r1.2 patch-ab
--- patches/patch-ab    2002/01/09 11:24:37     1.2
+++ patches/patch-ab    2003/09/19 13:53:38
@@ -1,7 +1,7 @@
 $NetBSD: patch-ab,v 1.2 2002/01/09 11:24:37 jlam Exp $
 
---- Makefile.orig      Wed Jul 28 15:05:02 1999
-+++ Makefile
+--- Makefile.orig      Wed Jul 28 23:05:02 1999
++++ Makefile   Fri Sep 19 14:51:24 2003
 @@ -31,8 +31,8 @@
  ID="@(#)Makefile:3.9 -- 5/15/91 19:30:15";
  SHELL = /bin/sh
@@ -18,7 +18,7 @@
  
  ## generic gcc CFLAGS.  -DTIME must be included
 -CFLAGS = -DTIME -Wall -pedantic -ansi
-+CFLAGS += -DTIME -Wall -pedantic -ansi
++#CFLAGS = -DTIME -Wall -pedantic -ansi
  
  # local directories
  PROGDIR = ./pgms
>Release-Note:
>Audit-Trail:
>Unformatted: