>Number:         22562
>Category:       pkg
>Synopsis:       pkgdiff should install man pages
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Thu Aug 21 21:14:00 UTC 2003
>Closed-Date:
>Last-Modified:
>Originator:     
>Release:        NetBSD 1.6.1_STABLE
>Organization:
http://bsd.reedmedia.net/
>Environment:
	
	
System: NetBSD rainier.reedmedia.net 1.6.1_STABLE NetBSD 1.6.1_STABLE (GENERIC) #0: Tue Aug 12 02:52:57 PDT 2003 reed@rainier.reedmedia.net:/usr/src/sys/arch/i386/compile/GENERIC i386
Architecture: i386
Machine: i386
>Description:
pkgsrc/pkgtools/pkgdiff wants to use the MANINSTALL.
But on some systems (like those using pkgsrc/devel/mk-files) may not
have that defined.
So the manual pages are not installed.
(Also, not tested, but the Makefile sets it to nothing if on SunOS too.)
The PLIST is not dynamic so it still thinks the manual pages are installed.

Also with some versions of NetBSD's make, the check like:

!empty(MANINSTALL:Mcatinstall)

will fail, please use:

Index: pkgtools/pkgdiff/Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/pkgtools/pkgdiff/Makefile,v
retrieving revision 1.39
diff -b -u -r1.39 Makefile
--- pkgtools/pkgdiff/Makefile	2003/07/17 22:52:17	1.39
+++ pkgtools/pkgdiff/Makefile	2003/08/21 21:11:39
@@ -44,7 +44,7 @@
 		< ${FILESDIR}/pkgdiff			\
 		> ${WRKSRC}/pkgdiff
 	${CP} ${FILESDIR}/pkgvi ${WRKSRC}
-.if !empty(MANINSTALL:Mcatinstall)
+.if defined(MANISTALL) && !empty(MANINSTALL:Mcatinstall)
 .  for FILE in mkpatches patchdiff pkgdiff pkgvi
 	${NROFF} -mandoc ${FILESDIR}/${FILE}.1 >${WRKSRC}/${FILE}.0
 .  endfor
@@ -53,10 +53,10 @@
 do-install:
 .for FILE in mkpatches patchdiff pkgdiff pkgvi
 	${INSTALL_SCRIPT} ${WRKSRC}/${FILE} ${PREFIX}/bin
-.   if !empty(MANINSTALL:Mcatinstall)
+.   if defined(MANINSTALL) && !empty(MANINSTALL:Mcatinstall)
 	${INSTALL_MAN} ${WRKSRC}/${FILE}.0 ${PREFIX}/man/cat1
 .   endif
-.   if !empty(MANINSTALL:Mmaninstall)
+.   if defined(MANINSTALL) && !empty(MANINSTALL:Mmaninstall)
 	${INSTALL_MAN} ${FILESDIR}/${FILE}.1 ${PREFIX}/man/man1
 .   endif
 .endfor

>How-To-Repeat:
	
>Fix:
Always install the man pages.

Maybe make the cat pages optional.

No patch provided at this time.
>Release-Note:
>Audit-Trail:
>Unformatted: