Subject: kern/22331: Redefinition in sys/dev/pcidevs
To: None <gnats-bugs@gnats.netbsd.org>
From: Quentin Garnier <cube@cubidou.net>
List: netbsd-bugs
Date: 08/01/2003 13:52:04
>Number:         22331
>Category:       kern
>Synopsis:       Redefinition in sys/dev/pcidevs
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    kern-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Aug 01 11:53:00 UTC 2003
>Closed-Date:
>Last-Modified:
>Originator:     Quentin Garnier
>Release:        NetBSD 1.6U
>Organization:
Quentin Garnier - cube@cubidou.net
"Feels like I'm fiddling while Rome is burning down.
Should I lay my fiddle down and take a rifle from the ground ?"
Leigh Nash/Sixpence None The Richer, Paralyzed, Divine Discontents, 2002.
>Environment:
System: NetBSD padme 1.6U NetBSD 1.6U (PADME) #3: Thu Jul 17 19:55:12 CEST 2003 cube@padme:/mnt/src/current/src/sys/arch/i386/compile/NVIDIA i386
Architecture: i386
Machine: i386
>Description:
	A value is duplicated in sys/dev/pcidevs for some ATI cards.
>How-To-Repeat:
	Compile libpci (I think) and look for a warning about a duplicated value:

/mnt/src/beru/dest/usr/include/dev/pci/pcidevs.h:969: warning: `PCI_PRODUCT_ATI_RADEON_9100' redefined
/mnt/src/beru/dest/usr/include/dev/pci/pcidevs.h:966: warning: this is the location of the previous definition
>Fix:

It appears to be a pasto. There is indeed a secondary Radeon 9100
product ID, thus the number changes too.

Index: pcidevs
===================================================================
RCS file: /cvsroot/src/sys/dev/pci/pcidevs,v
retrieving revision 1.559
diff -u -r1.559 pcidevs
--- pcidevs	2003/07/29 19:46:56	1.559
+++ pcidevs	2003/08/01 11:45:38
@@ -959,7 +959,7 @@
 product ATI RADEON_9100		0x514d	Radeon 9100 Series
 product ATI RADEON_7500		0x5157	Radeon 7500
 product ATI RADEON_7000		0x5159	Radeon 7000/VE
-product ATI RADEON_9100		0x514d	Radeon 9100 Series Secondary
+product ATI RADEON_9100_S	0x516d	Radeon 9100 Series Secondary
 product ATI RAGEGLPCI		0x5245	Rage 128 GL PCI
 product ATI RAGEGLAGP		0x5246	Rage 128 GL AGP 2x
 product ATI RAGEVRPCI		0x524b	Rage 128 VR PCI
>Release-Note:
>Audit-Trail:
>Unformatted: