Subject: pkg/22326: emulators/darcnes dumps core if not properly called
To: None <gnats-bugs@gnats.netbsd.org>
From: None <soren@bob.blef.org>
List: netbsd-bugs
Date: 07/31/2003 16:51:01
>Number:         22326
>Category:       pkg
>Synopsis:       emulators/darcnes dumps core if not properly called
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Thu Jul 31 23:52:00 UTC 2003
>Closed-Date:
>Last-Modified:
>Originator:     Soren Jacobsen
>Release:        NetBSD 1.6.1
>Organization:
>Environment:
pkgsrc as of 7/31/2003.
>Description:
darcnes will barf if you pass --system=something and don't supply a ROM on
the command line.
>How-To-Repeat:
bob:~$ darcnes --system=nes
Memory fault (core dumped) 
>Fix:
Add patch-ab and regen distinfo. Perhaps bump PKGREVISION.

patch-ab:
$NetBSD$

--- ui_x.c.orig	Thu Jul 31 15:58:05 2003
+++ ui_x.c	Thu Jul 31 15:59:56 2003
@@ -177,6 +177,12 @@
 	return 1;
     }
 
+    if (romfile == NULL) {
+	printf("rom not specified.\n");
+	usage(argv[0]);
+	return 1;
+    }
+
     initialize_window(display);
 
     activate_system(system_type, romfile);
>Release-Note:
>Audit-Trail:
>Unformatted: