Subject: pkg/22234: Fix security/skey installation permissions
To: None <gnats-bugs@gnats.NetBSD.org>
From: None <jonathan@perkin.org.uk>
List: netbsd-bugs
Date: 07/23/2003 12:51:39
>Number:         22234
>Category:       pkg
>Synopsis:       Fix security/skey installation permissions
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Jul 23 12:52:00 UTC 2003
>Closed-Date:
>Last-Modified:
>Originator:     Jonathan Perkin
>Release:        N/A
>Organization:
British Broadcasting Corporation
>Environment:
SunOS build0 5.8 Generic_108528-15 sun4u sparc SUNW,UltraSPARC-IIi-cEngine
>Description:
security/skey defines it's own INSTALL_* stuff, which doesn't pick up
either pkgsrc defaults or a local override.
>How-To-Repeat:
--<jonp@build0>-</home/jonp/src/pkgsrc/security/skey>--
-% bmake package
[...]
/usr/ucb/install -c -o jonp -g inet -d /home/jonp/pkg/lib
[Wrong permissions, should leave them as per mtree setup]
/usr/ccs/bin/sparcv9/strip: /home/jonp/pkg/bin/skey: cannot open file.
        Permission denied
[Didn't pick up my BINMODE=755 override, so strip(1) borks]

etc
>Fix:
http://www.perkin.org.uk/projects/netbsd/skey.patch

Index: distinfo
===================================================================
RCS file: /cvsroot/pkgsrc/security/skey/distinfo,v
retrieving revision 1.1.1.1
diff -u -r1.1.1.1 distinfo
--- distinfo    2002/07/26 09:10:06     1.1.1.1
+++ distinfo    2003/07/23 12:48:26
@@ -2,3 +2,4 @@
 
 SHA1 (skey-1.1.5.tar.bz2) = d55fb286098900cdf3eb6b174a720a06c722312a
 Size (skey-1.1.5.tar.bz2) = 61911 bytes
+SHA1 (patch-aa) = cb0447f064ca68e8e366d2976dca3f74dd9421e7
--- /dev/null   Wed Jul 23 09:59:45 2003
+++ patches/patch-aa    Wed Jul 23 13:44:17 2003
@@ -1,0 +1,34 @@
+$NetBSD$
+
+--- Makefile.in.orig   Thu May 10 17:10:49 2001
++++ Makefile.in        Wed Jul 23 12:31:50 2003
+@@ -18,10 +18,10 @@
+ AR=@AR@
+ RANLIB=@RANLIB@
+ INSTALL=@INSTALL@
+-INSTALL_PROGRAM=${INSTALL} -c -s -m 555
+-INSTALL_MAN=${INSTALL} -c -m 444
+-INSTALL_SCRIPT=${INSTALL} -c -m 555
+-INSTALL_DATA=${INSTALL} -c -m 444
++INSTALL_PROGRAM=@INSTALL_PROGRAM@
++INSTALL_MAN=@INSTALL_DATA@
++INSTALL_SCRIPT=@INSTALL_SCRIPT@
++INSTALL_DATA=@INSTALL_DATA@
+ PERL=@PERL@
+ SENDMAIL=@SENDMAIL@
+ TOUCH=@TOUCH@
+@@ -88,14 +88,6 @@
+       done
+ 
+ install: ${TARGETS}
+-      $(INSTALL) -d $(DESTDIR)$(bindir)
+-      $(INSTALL) -d $(DESTDIR)$(libdir)
+-      $(INSTALL) -d $(DESTDIR)$(mandir)
+-      $(INSTALL) -d $(DESTDIR)$(etcdir)
+-      $(INSTALL) -d $(DESTDIR)$(mandir)/$(mansubdir)1
+-      $(INSTALL) -d $(DESTDIR)$(mandir)/$(mansubdir)8
+-      $(INSTALL) -d $(DESTDIR)$(includedir)
+-      $(INSTALL) -d $(DESTDIR)$(sysconfdir)
+       ${INSTALL_DATA} libskey.a $(DESTDIR)$(libdir)
+       ${INSTALL_DATA} ${HDRS} $(DESTDIR)$(includedir)
+       @for target in ${TARGETS}; do \
>Release-Note:
>Audit-Trail:
>Unformatted: