Subject: pkg/22039: www/jakarta-tomcat: use OWN_DIRS properly
To: None <gnats-bugs@gnats.netbsd.org>
From: None <tv@pobox.com>
List: netbsd-bugs
Date: 07/02/2003 23:09:51
>Number:         22039
>Category:       pkg
>Synopsis:       www/jakarta-tomcat: use OWN_DIRS properly
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Thu Jul 03 03:13:01 UTC 2003
>Closed-Date:
>Last-Modified:
>Originator:     Todd Vierling
>Release:        NetBSD 1.6.1_STABLE
>Organization:
	DUH.ORG:  Pointing out the obvious since 1994.
>Environment:
>Description:

As currently in pkgsrc, www/jakarta-tomcat uses MAKE_DIRS (and not
even properly, because it's reset three times 8-) where it should
be using OWN_DIRS, so that the package can clean itself up if no
customized files have been created in those directories.

>How-To-Repeat:

cd pkgsrc/www/jakarta-tomcat
make install
make deinstall

...notice that the deinstall asks you to delete empty directories.

>Fix:

Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/www/jakarta-tomcat/Makefile,v
retrieving revision 1.36
diff -u -r1.36 Makefile
--- Makefile	2003/06/03 17:02:47	1.36
+++ Makefile	2003/07/03 03:06:52
@@ -25,9 +25,9 @@
 
 USE_PKGINSTALL=	yes
 OWN_DIRS=	${PREFIX}/tomcat
-MAKE_DIRS=	${PREFIX}/tomcat/conf
-MAKE_DIRS=	${PREFIX}/tomcat/logs
-MAKE_DIRS=	${PREFIX}/tomcat/webapps
+OWN_DIRS+=	${PREFIX}/tomcat/conf
+OWN_DIRS+=	${PREFIX}/tomcat/logs
+OWN_DIRS+=	${PREFIX}/tomcat/webapps
 CFILES=		server.xml web.xml tomcat-users.xml jni_server.xml
 CFILES+=	tomcat.policy workers.properties
 
>Release-Note:
>Audit-Trail:
>Unformatted: