Subject: port-arm/21962: small bug in arm32/cpuswitch.S
To: None <gnats-bugs@gnats.netbsd.org>
From: Jachym Holecek <freza@psi.cz>
List: netbsd-bugs
Date: 06/23/2003 03:25:26
>Number: 21962
>Category: port-arm
>Synopsis: #ifdef instead of #ifndef
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: port-arm-maintainer
>State: open
>Class: sw-bug
>Submitter-Id: net
>Arrival-Date: Sun Jun 22 23:18:00 UTC 2003
>Closed-Date:
>Last-Modified:
>Originator: freza
>Release: NetBSD-current as of Sat Jun 21 05:38:44 CEST 2003
>Organization:
CESNET
>Environment:
System: NetBSD gloom 1.6 NetBSD 1.6 (GLOOM) #4: Mon Jan 27 14:40:31 CET 2003 jh@gloom:/usr/src/sys/arch/i386/compile/GLOOM i386
Architecture: arm
Machine: arm
>Description:
The cpu_switch routine in arm32/cpuswitch.S uses #ifdef when #ifndef should
be used at point of checking for existence of spl0.
>How-To-Repeat:
The problem probably never shows up. I found it going trough the ARM code.
>Fix:
--- cpuswitch.S Sat Jun 7 22:20:31 2003
+++ cpuswitch.S.new Mon Jun 23 03:18:59 2003
@@ -268,7 +268,7 @@
mov r0, #(IPL_NONE)
bl _C_LABEL(_spllower)
#else /* ! __NEWINTR */
-#ifdef spl0
+#ifndef spl0
mov r0, #(_SPL_0)
bl _C_LABEL(splx)
#else
>Release-Note:
>Audit-Trail:
>Unformatted: