Subject: pkg/21490: databases/openldap/buildlink2.mk erroneously brings in pthreads
To: None <gnats-bugs@gnats.netbsd.org>
From: None <tv@pobox.com>
List: netbsd-bugs
Date: 05/07/2003 11:53:35
>Number:         21490
>Category:       pkg
>Synopsis:       databases/openldap/buildlink2.mk erroneously brings in pthreads
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed May 07 15:58:00 UTC 2003
>Closed-Date:
>Last-Modified:
>Originator:     Todd Vierling
>Release:        NetBSD 1.6.1
>Organization:
	DUH.ORG:  Pointing out the obvious since 1994.
>Environment:
>Description:

In databases/openldap/buildlink2.mk:

.include "../../mk/pthread.buildlink2.mk"

This is wrong.  pthreads is only used by openldap to build slurpd, and
most dependencies on openldap don't give a damn about pthreads.  (Do a
"ldd /usr/pkg/lib/libldap.so" if you don't believe me.)  Packages that
need both pthreads and openldap should be including both of their
buildlink2 files explicitly.

>How-To-Repeat:
>Fix:

Index: buildlink2.mk
===================================================================
RCS file: /pub/NetBSD-CVS/pkgsrc/databases/openldap/buildlink2.mk,v
retrieving revision 1.4
diff -u -r1.4 buildlink2.mk
--- buildlink2.mk	2003/05/02 11:54:13	1.4
+++ buildlink2.mk	2003/05/07 15:50:28
@@ -30,8 +30,6 @@
 .  include "../../security/cyrus-sasl/buildlink2.mk"
 .endif
 
-.include "../../mk/pthread.buildlink2.mk"
-
 BUILDLINK_TARGETS+=	openldap-buildlink
 
 openldap-buildlink: _BUILDLINK_USE
>Release-Note:
>Audit-Trail:
>Unformatted: