Subject: pkg/20831: security/openssh should use RCD_SCRIPTS_EXAMPLEDIR in PLIST
To: None <gnats-bugs@gnats.netbsd.org>
From: None <reed@reedmedia.net>
List: netbsd-bugs
Date: 03/20/2003 21:35:23
>Number:         20831
>Category:       pkg
>Synopsis:       security/openssh has wrong rc.d directory -- should use RCD_SCRIPTS_EXAMPLEDIR in PLIST
>Confidential:   yes
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Thu Mar 20 21:36:00 PST 2003
>Closed-Date:
>Last-Modified:
>Originator:     
>Release:        NetBSD 1.6
>Organization:
http://bsd.reedmedia.net/
>Environment:
	
	
System: NetBSD rainier.reedmedia.net 1.6 NetBSD 1.6 (JCR-20020927) #3: Sat Sep 28 13:40:20 PDT 2002 reed@rainier.reedmedia.net:/usr/src/sys/arch/i386/compile/JCR-20020927 i386
Architecture: i386
Machine: i386
>Description:
The PLIST for security/openssh has wrong rc.d directory.

Many other packages have same problem. Probably the simple fix
is to have the PLIST_SUBST set for all (in mk/bsd.pkg.mk) and
then fix the PLISTs.
>How-To-Repeat:
Install security/openssh when your RCD_SCRIPTS_EXAMPLEDIR
is not the default and notice that +CONTENTS is wrong.
>Fix:

diff -b -u -r1.94 Makefile
--- security/openssh/Makefile	2003/01/28 22:04:06	1.94
+++ security/openssh/Makefile	2003/03/21 05:29:46
@@ -41,10 +41,9 @@
 
 PKG_SYSCONFSUBDIR=	ssh
 MANDIR=			man
-RCD_SCRIPTS_EGDIR=	etc/rc.d
 
 PLIST_SUBST+=		MANDIR=${MANDIR}
-PLIST_SUBST+=		RCD_SCRIPTS_EGDIR=${RCD_SCRIPTS_EGDIR}
+PLIST_SUBST+=		RCD_SCRIPTS_EXAMPLEDIR=${RCD_SCRIPTS_EXAMPLEDIR}
 
 USE_BUILDLINK2=		yes
 USE_PKGINSTALL=		yes
Index: security/openssh/PLIST
===================================================================
RCS file: /cvsroot/pkgsrc/security/openssh/PLIST,v
retrieving revision 1.7
diff -b -u -r1.7 PLIST
--- security/openssh/PLIST	2002/06/28 17:10:17	1.7
+++ security/openssh/PLIST	2003/03/21 05:29:46
@@ -7,7 +7,7 @@
 bin/ssh-agent
 bin/ssh-keygen
 bin/ssh-keyscan
-${RCD_SCRIPTS_EGDIR}/sshd
+${RCD_SCRIPTS_EXAMPLEDIR}/sshd
 libexec/sftp-server
 libexec/ssh-keysign
 ${MANDIR}/man1/scp.1
>Release-Note:
>Audit-Trail:
>Unformatted: