Subject: kern/19313: MSG_IDENTIFY_LUNMASK redefined in syssrc/sys/dev/scsipi/scsi_message.h
To: None <gnats-bugs@gnats.netbsd.org>
From: Lubomir Sedlacik <salo@Xtrmntr.org>
List: netbsd-bugs
Date: 12/07/2002 11:10:10
>Number:         19313
>Category:       kern
>Synopsis:       MSG_IDENTIFY_LUNMASK redefined in syssrc/sys/dev/scsipi/scsi_message.h
>Confidential:   no
>Severity:       critical
>Priority:       high
>Responsible:    kern-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Dec 07 02:11:00 PST 2002
>Closed-Date:
>Last-Modified:
>Originator:     Lubomir Sedlacik
>Release:        NetBSD 1.6K
>Organization:
>Environment:
>Description:

in rev. 1.9 MSG_IDENTIFY_LUNMASK was added to
syssrc/sys/dev/scsipi/scsi_message.h which conflicts with
syssrc/sys/dev/ic/ihareg.h and result is build failure:

 In file included from /cvs/src/sys/dev/ic/iha.c:61:
 /cvs/src/sys/dev/ic/ihareg.h:148: warning: `MSG_IDENTIFY_LUNMASK' redefined
 /cvs/src/sys/dev/scsipi/scsi_message.h:44: warning: this is the location of the previous definition
 nbmkdep: compile failed.
 *** Error code 1

>How-To-Repeat:

try to build -current kernel with scsi support
>Fix:

Index: scsi_message.h
===================================================================
RCS file: /cvsroot/syssrc/sys/dev/scsipi/scsi_message.h,v
retrieving revision 1.10
diff -u -r1.10 scsi_message.h
--- scsi_message.h      2002/12/06 23:04:16     1.10
+++ scsi_message.h      2002/12/07 09:36:47
@@ -41,7 +41,6 @@
 #define MSG_IDENTIFY(lun, disc)        \
        (MSG_IDENTIFYFLAG | ((disc) ? MSG_IDENTIFY_DISCFLAG : 0) | (lun))
 #define MSG_ISIDENTIFY(m)      ((m) & MSG_IDENTIFYFLAG)
-#define MSG_IDENTIFY_LUNMASK   0x3f
 
 /* Extended messages (opcode and length) */
 #define MSG_EXT_SDTR           0x01

>Release-Note:
>Audit-Trail:
>Unformatted: