Subject: pkg/18627: lang/gcc PLIST.SunOS inconsistency (etc/${PKGNAME}.mk)
To: None <gnats-bugs@gnats.netbsd.org>
From: Lubomir Sedlacik <salo@Xtrmntr.org>
List: netbsd-bugs
Date: 10/12/2002 08:09:35
>Number:         18627
>Category:       pkg
>Synopsis:       lang/gcc PLIST.SunOS inconsistency (etc/${PKGNAME}.mk)
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Oct 11 23:10:00 PDT 2002
>Closed-Date:
>Last-Modified:
>Originator:     Lubomir Sedlacik
>Release:        NetBSD 1.6
>Organization:
>Environment:
>Description:

there is an inconsistency in lang/gcc/PLIST.SunOS, the etc/${PKGNAME}.mk file
is not installed on Solaris due to conditional in Makefile.

>How-To-Repeat:

try to install lang/gcc on Solaris

>Fix:

there are two ways of fixing this.  it depends on whether we want to provide
this file even for Solaris (as PLIST.SunOS indicates) or not (as Makefile
indicates).

variant A:

Index: PLIST.SunOS
===================================================================
RCS file: /cvsroot/pkgsrc/lang/gcc/PLIST.SunOS,v
retrieving revision 1.7
diff -u -r1.7 PLIST.SunOS
--- PLIST.SunOS	5 Oct 2002 20:54:52 -0000	1.7
+++ PLIST.SunOS	12 Oct 2002 05:58:20 -0000
@@ -14,7 +14,6 @@
 bin/gcov
 bin/jcf-dump
 bin/jv-scan
-etc/${PKGNAME}.mk
 include/g++-3/PlotFile.h
 include/g++-3/SFile.h
 include/g++-3/algo.h


variant B:

Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/lang/gcc/Makefile,v
retrieving revision 1.47
diff -u -r1.47 Makefile
--- Makefile	27 Sep 2002 12:28:15 -0000	1.47
+++ Makefile	12 Oct 2002 06:03:09 -0000
@@ -74,16 +74,14 @@
 post-build:
 	@${SED} ${FILES_SUBST_SED} ${FILESDIR}/gcc.mk > ${WRKDIR}/gcc.mk
 
+post-install:
 .if (${OPSYS} == SunOS)
 #
 # remove empty file and directories that show up when one does:
 #	make install; make deinstall; make install
 #
-post-install:
 	-cd ${GCC_ARCHDIR}/include && ${RM} -f fixed && ${RMDIR} v7 v9
 .else
-post-install:
-	${INSTALL_DATA} ${WRKDIR}/gcc.mk ${PREFIX}/etc/${PKGNAME}.mk
 .  if exists(/usr/include/g++/FlexLexer.h)
 	${LN} -fs /usr/include/g++/FlexLexer.h				\
 		${GCC_PREFIX}/include/g++-3/FlexLexer.h
@@ -98,6 +96,7 @@
 		| ${SORT} -r | ${SED} -e "s,${PREFIX}/,@dirrm ,g"	\
 		>> ${PLIST_SRC}
 .endif
+	${INSTALL_DATA} ${WRKDIR}/gcc.mk ${PREFIX}/etc/${PKGNAME}.mk
 
 .include "../../mk/texinfo.mk"
 .include "../../mk/bsd.pkg.install.mk"
>Release-Note:
>Audit-Trail:
>Unformatted: