Subject: pkg/18009: p5-DBD-postgresql fails 'make test'
To: None <gnats-bugs@gnats.netbsd.org>
From: None <jarle@uninett.no>
List: netbsd-bugs
Date: 08/21/2002 11:20:35
>Number:         18009
>Category:       pkg
>Synopsis:       p5-DBD-postgresql fails 'make test'
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Aug 21 02:21:00 PDT 2002
>Closed-Date:
>Last-Modified:
>Originator:     Jarle Greipsland
>Release:        NetBSD 1.6E
>Organization:
UNINETT
>Environment:
	
	
System: NetBSD darling.urc.uninett.no 1.6E NetBSD 1.6E (DARLING) #13: Mon Aug 5 13:06:25 CEST 2002 jarle@darling.urc.uninett.no:/usr/src/sys/arch/i386/compile/DARLING i386
Architecture: i386
Machine: i386
>Description:
I set up the test environment for the p5-DBD-postgresql package, and ran
'make test'.  Several of the tests failed:

$ export DBDPG_MAINTAINER=1
$ export DBDPG_TEST_HOST=127.0.0.1
$ export DBDPG_TEST_DB=dbdtest
$ export DBDPG_TEST_USER=<user>
$ export DBDPG_TEST_PASS=<password>
$ make test
PERL_DL_NONLAZY=1 /usr/pkg/bin/perl -Iblib/arch -Iblib/lib -I/usr/pkg/lib/perl5/5.6.1/i386-netbsd -I/usr/pkg/lib/perl5/5.6.1 -e 'use Test::Harness qw(&runtests $verbose); $verbose=0; runtests @ARGV;' t/*.t
t/00basic...........ok                                                       
t/01connect.........ok                                                       
t/01setup...........ok                                                       
t/02prepare.........ok                                                       
t/03bind............ok                                                       
t/04execute.........FAILED tests 5-7                                         
        Failed 3/10 tests, 70.00% okay
t/05fetch...........ok                                                       
t/06disconnect......ok                                                       
t/07reuse...........dubious                                                  
        Test returned status 0 (wstat 11, 0xb)
t/08txn.............ok                                                       
t/09autocommit......FAILED tests 4, 7                                        
        Failed 2/10 tests, 80.00% okay
t/10transition......ok                                                       
t/11quoting.........ok                                                       
t/12placeholders....ok                                                       
t/13pgtype..........ok                                                       
t/99cleanup.........ok                                                       
Failed Test      Status Wstat Total Fail  Failed  List of Failed
--------------------------------------------------------------------------------
t/04execute.t                         10    3  30.00%  5-7
t/07reuse.t                0    11    ??   ??       %  ??
t/09autocommit.t                      10    2  20.00%  4, 7
Failed 3/16 test scripts, 81.25% okay. 5/101 subtests failed, 95.05% okay.
*** Error code 2

Stop.
make: stopped in /usr/pkgsrc/databases/p5-DBD-postgresql/work/DBD-Pg-1.13

In particular it seemed weird to me that the autocommit tests should fail.
After all the patches in the patches directory seem aimed at fixing some
problem with autocommit.  Also, some investigation revealed that the failed
t/07reuse test is due to a segmentation fault -- not good.
I decided to remove the patches, and re-make the package.  The subsequent
run of 'make test' showed some improvements:

$ make test
PERL_DL_NONLAZY=1 /usr/pkg/bin/perl -Iblib/arch -Iblib/lib -I/usr/pkg/lib/perl5/5.6.1/i386-netbsd -I/usr/pkg/lib/perl5/5.6.1 -e 'use Test::Harness qw(&runtests $verbose); $verbose=0; runtests @ARGV;' t/*.t
t/00basic...........ok
t/01connect.........ok
t/01setup...........ok
t/02prepare.........ok
t/03bind............ok
t/04execute.........FAILED tests 5-7
        Failed 3/10 tests, 70.00% okay
t/05fetch...........ok
t/06disconnect......ok
t/07reuse...........ok
t/08txn.............ok
t/09autocommit......ok
t/10transition......ok
t/11quoting.........ok
t/12placeholders....ok
t/13pgtype..........ok
t/99cleanup.........ok
Failed Test   Status Wstat Total Fail  Failed  List of Failed
--------------------------------------------------------------------------------
t/04execute.t                 10    3  30.00%  5-7
Failed 1/16 test scripts, 93.75% okay. 3/104 subtests failed, 97.12% okay.
*** Error code 25

Stop.
make: stopped in /usr/pkgsrc/databases/p5-DBD-postgresql/work/DBD-Pg-1.13

Could someone more familiar with the patches look into why they
introduce more problems than what they seem to solve?  Should they be
removed?
	
>How-To-Repeat:
Install the p5-DBD-postgresql package, set up the necessary test environment,
and run 'make test'.
	
>Fix:
	
Unknown.
>Release-Note:
>Audit-Trail:
>Unformatted: