Subject: kern/17394: a DEBUG printf() in UVM is too terse
To: None <gnats-bugs@gnats.netbsd.org>
From: Greg A. Woods <woods@weird.com>
List: netbsd-bugs
Date: 06/25/2002 16:59:39
>Number:         17394
>Category:       kern
>Synopsis:       a DEBUG printf() in UVM is too terse
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    kern-bug-people
>State:          open
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Tue Jun 25 14:00:00 PDT 2002
>Closed-Date:
>Last-Modified:
>Originator:     Greg A. Woods
>Release:        NetBSD-current 2002/06/24
>Organization:
Planix, Inc.; Toronto, Ontario; Canada
>Environment:
System: NetBSD
>Description:

	a DEBUG printf() in UVM uses the overloaded term "comm"

	(I'm not sure this should be a DEBUG printf -- maybe it should
	be logged at some medium level such as LOG_NOTICE?)

>How-To-Repeat:

	search for other confusing uses of "comm" in kernel messages...

>Fix:

Index: uvm_mmap.c
===================================================================
RCS file: /cvs/master/m-NetBSD/main/syssrc/sys/uvm/uvm_mmap.c,v
retrieving revision 1.63
diff -c -c -r1.63 uvm_mmap.c
*** uvm_mmap.c	22 Mar 2002 11:06:33 -0000	1.63
--- uvm_mmap.c	25 Jun 2002 20:56:37 -0000
***************
*** 395,401 ****
  		if ((flags & (MAP_SHARED|MAP_PRIVATE)) == 0) {
  #if defined(DEBUG)
  			printf("WARNING: defaulted mmap() share type to "
! 			   "%s (pid %d comm %s)\n", vp->v_type == VCHR ?
  			   "MAP_SHARED" : "MAP_PRIVATE", p->p_pid,
  			    p->p_comm);
  #endif
--- 395,401 ----
  		if ((flags & (MAP_SHARED|MAP_PRIVATE)) == 0) {
  #if defined(DEBUG)
  			printf("WARNING: defaulted mmap() share type to "
! 			   "%s (pid %d, commmand %s)\n", vp->v_type == VCHR ?
  			   "MAP_SHARED" : "MAP_PRIVATE", p->p_pid,
  			    p->p_comm);
  #endif
>Release-Note:
>Audit-Trail:
>Unformatted: