Subject: pkg/16312: unneccessary include of devel/pth/buildlink.mk in www/dillo complicates build on Solaris
To: None <gnats-bugs@gnats.netbsd.org, Benjamin.Wong@cc.gatech.edu, fredb@netbsd.org>
From: Lubomir Sedlacik <salo@Xtrmntr.org>
List: netbsd-bugs
Date: 04/12/2002 04:24:11
>Number:         16312
>Category:       pkg
>Synopsis:       unneccessary include of devel/pth/buildlink.mk in www/dillo complicates build on Solaris
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Apr 11 19:25:01 PDT 2002
>Closed-Date:
>Last-Modified:
>Originator:     Lubomir Sedlacik
>Release:        NetBSD 1.5ZB
>Organization:
>Environment:
>Description:

www/dillo package includes ../../devel/pth/buildlink.mk directly instead of
using prefered ../../mk/pthread.buildlink.mk, which is not needed at all,
because it already has dependency on pthreads from ../../x11/gtk/buildlink.mk
-> ../../devel/glib/buildlink.mk -> ../../mk/pthread.buildlink.mk.

Solaris uses native pthreads library and thus it's undesired to compile pth
package. devel/glib take care about this in a proper way by including
../../mk/pthread.buildlink.mk.

>How-To-Repeat:
>Fix:

remove include "../../devel/pth/buildlink.mk" from www/dillo/Makefile.

patch follows:

Index: Makefile
===================================================================
RCS file: /pub/NetBSD-CVS/pkgsrc/www/dillo/Makefile,v
retrieving revision 1.5
diff -u -r1.5 Makefile
--- Makefile	2002/03/13 17:37:51	1.5
+++ Makefile	2002/04/12 02:09:40
@@ -18,7 +18,6 @@
 	${INSTALL_DATA_DIR} ${PREFIX}/share/examples/dillo
 	${INSTALL_DATA} ${WRKSRC}/dillorc ${PREFIX}/share/examples/dillo
 
-.include	"../../devel/pth/buildlink.mk"
 .include	"../../graphics/jpeg/buildlink.mk"
 .include	"../../graphics/png/buildlink.mk"
 .include	"../../x11/gtk/buildlink.mk"
>Release-Note:
>Audit-Trail:
>Unformatted: