>Number:         16019
>Category:       kern
>Synopsis:       bridge_ioctl_add() fail to free() i !ethernet
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    kern-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Mar 22 16:04:00 PST 2002
>Closed-Date:
>Last-Modified:
>Originator:     Love
>Release:        NetBSD 1.5ZB
>Organization:
	
>Environment:
	
	
System: NetBSD nutcracker.stacken.kth.se 1.5ZB NetBSD 1.5ZB (NUTCRACKER) #7: Sun Mar 17 15:01:14 CET 2002 lha@nutcracker.stacken.kth.se:/usr/src/sys/arch/i386/compile/NUTCRACKER i386
Architecture: i386
Machine: i386
>Description:
	
	syssrc/sys/net/if_bridge.c:bridge_ioctl_add() failes to free
	memory when its called with a non ethernet interface.

>How-To-Repeat:

	Code inspection.

>Fix:

Index: if_bridge.c
===================================================================
RCS file: /sources/netbsd/NetBSD-cvs/syssrc/sys/net/if_bridge.c,v
retrieving revision 1.4
diff -u -u -w -r1.4 if_bridge.c
--- if_bridge.c	2002/03/08 20:48:43	1.4
+++ if_bridge.c	2002/03/22 23:57:47
@@ -577,7 +577,8 @@
 		break;
 
 	default:
-		return (EINVAL);
+		error = EINVAL;
+		goto out;
 	}
 
 	bif->bif_ifp = ifs;
	
>Release-Note:
>Audit-Trail:
>Unformatted: