[ On Monday, March 18, 2002 at 18:54:14 (+0900), Shin'ichiro TAYA wrote: ]
> Subject: Re: pkg/15952: www/galeon-1.2.0 does not build with mozilla-0.9.9
>
> From: woods@weird.com (Greg A. Woods)
> Subject: Re: pkg/15952: www/galeon-1.2.0 does not build with mozilla-0.9.9
> Date: Mon, 18 Mar 2002 03:55:18 -0500 (EST)
> > 
> > [ On Monday, March 18, 2002 at 17:33:08 (+0900), Shin'ichiro TAYA wrote: ]
> > > Subject: Re: pkg/15952: www/galeon-1.2.0 does not build with mozilla-0.9.9
> > >
> > > Hi, i'm analyzing galeon issue.
> > > Could you check your /usr/pkg/include/glib/glib-1.2/glib.h and how
> > > NULL is defined (maybe line# 121)?
> > 
> > 	#ifndef NULL
> > 	#define NULL    ((void*) 0)
> > 	#endif
> > 
> > Which is far less than ideal for C -- NULL should always be just "0".
> 
> According to PR pkg/14150, this part should be:
> 
> #ifndef	NULL
> #include <sys/null.h>
> #endif

> Could you manually change definiiton of NULL to above and try again?
> If succeeded, this is a problem of glib.

Well being the pedant I am I set it explicitly to "0", and galeon
compiles without too many warnings, and no errors, and seems to run
quite well.....

> See PR pkg/14150 for detail.
> http://www.netbsd.org/cgi-bin/query-pr-single.pl?number=14150

While I can sort of sometimes appreciate the desire to have NULL used
only when pointer types are supposed to be used, such a goal is not
viable for the vast amount of code not maintained by and within NetBSD.

For the vast majority of third party code the only valid definition of
NULL is '0'.

-- 
								Greg A. Woods

+1 416 218-0098;  <gwoods@acm.org>;  <g.a.woods@ieee.org>;  <woods@robohack.ca>
Planix, Inc. <woods@planix.com>; VE3TCP; Secrets of the Weird <woods@weird.com>