Subject: pkg/14834: games/lincity has compilation problems
To: None <gnats-bugs@gnats.netbsd.org>
From: None <kre@munnari.OZ.AU>
List: netbsd-bugs
Date: 12/04/2001 18:10:16
>Number:         14834
>Category:       pkg
>Synopsis:       games/lincity doesn't compile
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Dec 04 03:10:00 PST 2001
>Closed-Date:
>Last-Modified:
>Originator:     Robert Elz
>Release:        NetBSD-current 20011127
>Organization:
	Prince of Songkla University
>Environment:
	
System: NetBSD fuchsia 1.5Y NetBSD 1.5Y (FUCHSIA) #2: Mon Nov 26 13:41:27 ICT 2001     kre@fuchsia:/usr/obj/sys/FUCHSIA i386


>Description:
	games/lincity has a few trivial compilation problems
	(warnings being treated as errors ...)

>How-To-Repeat:
	cd pkgsrc/games/lincity
	make

	Watch for ...

gcc -c lcx11.cxx -o lcx11.o -O2  -I/usr/obj/pkg/games/lincity/work.i386/.buildli
nk/include -O2 -I/usr/pkg/share/x11-links/include -Wall -Wpointer-arith -Wcast-a
lign -Winline -DLIBDIR=\"/usr/pkg/share/lincity\" -I/usr/pkg/share/x11-links/inc
lude -DLC_X11
lcx11.cxx: In function `void refresh_screen(int, int, int, int)':
lcx11.cxx:719: passing `char *' as argument 8 of `Fgl_putbox_low(long unsigned i
nt, int, int, int, int, int, int, unsigned char *, int, int, int)' changes signe
dness
lcx11.cxx: In function `void init_icon_pixmap(int)':
lcx11.cxx:1118: warning: unused variable `int y'
lcx11.cxx:1118: warning: unused variable `int x'
*** Error code 1 

>Fix:
	Adding meaningless unnecessary initialisations for x & y
	(outside of ifdef's - the uses of the var's are #ifdef'd away)
	and a "(unsigned char *)" cast to the func call arg
	cleaned up all warnings and allowed the pkg to build properly
>Release-Note:
>Audit-Trail:
>Unformatted: