Subject: Re: pkg/14684: make clean in pkgsrc is waaay too slow
To: Alistair Crooks , gabriel rosenkoetter <gr@eclipsed.net>
From: John Franklin <franklin@elfie.org>
List: netbsd-bugs
Date: 11/22/2001 22:48:53
On Fri, Nov 23, 2001 at 02:26:59AM +0100, Hubert Feyrer (and others) wrote
(or something like):
> Nice idea. Two points:
> 
>  * "make clean" doesn't nuke distfile, so should fastclean. If anything,
>    make a "fastdistclean|
>  * I'm have OBJMACHINE set, as such I don't have */*/work but
>    */*/work.sparc (etc.), this needs to be takein into account.

On Thu, Nov 22, 2001 at 08:06:34PM +0100, Alistair Crooks wrote:
> And what about if you have WRKOBJDIR set?

On Thu, Nov 22, 2001 at 06:26:23PM -0600, Frederick Bruckman wrote:
> This doesn't seem quite right. You're going to nuke "work" whether the
> package and category have been added to ${SUBDIR} or not? If that's
> what you want, why not just do "rm ..." on the command line?

All good points.  The patch could certainly be modified to check 
and account for any or all the variables in the build system.  And 
pretty trivially, I should think.  Clearly, though, it should be done
by someone with more knowlege of the dozen-odd mk files than I have.

On Fri, Nov 23, 2001 at 02:26:59AM +0100, Hubert Feyrer wrote:
> It should be discussed on tech-pkg if we want this feature.

Seems to have more than one advocate, albeit not in its present form.

On Thu, Nov 22, 2001 at 02:41:20PM -0500, gabriel rosenkoetter wrote:
> can get them more quickly onto all my other machines. I still want
> to be able to make clean a package if I think local modifications
> are causing some brokenness in the build of that package (and,
> anyway, we make clean after make install by default these days, no?).

I've seen it remove the package I'm building, but not the dependent
packages.  Building something like Galeon on a virgin system can leave
quite a bit.

I just tried it with tk and it didn't clean either tk or tcl.  This is with
a current pkgsrc and the November 11 snapshot installed.  Could be I've got
something set wrong on my system.  <shrug>

jf
-- 
John Franklin
franklin@elfie.org
ICBM: N37 12'54", W80 27'14" Z+2100'