Subject: bin/13571: telnetd won't compile without -DLINEMODE
To: None <gnats-bugs@gnats.netbsd.org>
From: None <o.vd.linden@quicknet.nl>
List: netbsd-bugs
Date: 07/27/2001 22:43:50
>Number:         13571
>Category:       bin
>Synopsis:       telnetd without -DLINEMODE does not compile
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    bin-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Jul 27 13:43:01 PDT 2001
>Closed-Date:
>Last-Modified:
>Originator:     Onno van der Linden
>Release:        <NetBSD-current source date> 23 July 2001
>Organization:
	
>Environment:
	
System: NetBSD sheep 1.5W NetBSD 1.5W (SHEEP) #3: Tue Jul 24 14:06:59 MEST 2001 root@sheep:/usr/src/sys/arch/i386/compile/SHEEP i386
Architecture: i386
Machine: i386
>Description:
        Making telnetd without -DLINEMODE in Makefile is not possible
(don't ask, brain damaged linemode implementation of terminal server)
cc1: warnings being treated as errors
/usr/src/libexec/telnetd/state.c:1571: warning: function declaration isn't a prototype
The doclientstat() prototype is surrounded by #ifdef LINEMODE and #endif, but
the function itself isn't.
	
>How-To-Repeat:
	remove -DLINEMODE from /usr/src/libexec/telnetd/Makefile.
  	make clean
	make
>Fix:
*** /usr/src/libexec/telnetd/state.c.orig	Fri Jul 20 12:29:51 2001
--- /usr/src/libexec/telnetd/state.c	Fri Jul 27 22:35:30 2001
***************
*** 1566,1576 ****
--- 1566,1578 ----
  
  }  /* end of suboption */
  
+ #ifdef LINEMODE
  	void
  doclientstat()
  {
  	clientstat(TELOPT_LINEMODE, WILL, 0);
  }
+ #endif
  
  	void
  send_status()
>Release-Note:
>Audit-Trail:
>Unformatted: