Subject: Re: pkg/12417: digest problem with sha1 on alpha, unaligned access
To: Simon Burge <simonb@wasabisystems.com>
From: Alistair Crooks <agc@pkgsrc.org>
List: netbsd-bugs
Date: 03/16/2001 09:03:01
On Fri, Mar 16, 2001 at 03:46:08PM +1100, Simon Burge wrote:
> Simon Burge wrote:
> 
> > Andrew Brown wrote:
> > 
> > > >Number:         12417
> > > >Category:       pkg
> > > >Synopsis:       digest problem with sha1 on alpha, unaligned access
> 
> Ok, ick.  My patch is to libc, which means that this wont fix older
> version of NetBSD that include sha1 in libc (eg, a clean 1.5 install).
> 
> Perhaps we should always use (a fixed version of) files/sha1.c for all
> versions of NetBSD prior to 1.6 (or 1.5S or whatever we're up to)?
> Al - what's your thoughts on this?

I'll pull in a fixed version (from the rest of the PR, it seems that
Andrew still gets warnings) when it's fixed in libc.

As far as digest goes, it has its own versioning system, loosely based
on the date, but with some room for fun.  There is a DIGEST_REQD
version in pkgsrc which can be bumped when necessary to pull in the
fixed version, which ensures that people will be using the latest
version.

I've also included a small regression test in the digest package, and
would be grateful if people could beef that up a bit, so that we don't
get bitten in future.

Thanks,
Al