Subject: Re: kern/12298: fairly impressive cross-compilation bogon in sys/lib/libsa/tftp.c
To: Todd Vierling <tv@wasabisystems.com>
From: Chris G. Demetriou <cgd@netbsd.org>
List: netbsd-bugs
Date: 02/28/2001 17:56:32
Todd Vierling <tv@wasabisystems.com> writes:
> The solution is *really* simple:  Move all files which are not libc-tied
> from src/include/arpa to src/sys/arpa -- should be everything but
> "arpa/inet.h".  Then add a bsd.kinc.mk based Makefile to install the
> headers.

I'd object to this based on the thought of, "why move it to the kernel
if it's not actually going to be used there?"  Also not sure the
notion of creating a subdir of sys is a good one.

I'd say if you want to do this, best to move src/include/arpa/tftp.h
to src/sys/sys/tftp.h, and that's it.

If you pursue this, you also have to make sure that a symlink from
<arpa/whatever.h> points to the correct place in the kernel headers.


> But as far as I'm concerned, the non-"arpa/inet.h" files only
> describe protocol structures and constants, and thus are useful to kernel
> and standalone code.  "arpa/inet.h", on the other hand, is just a C library
> function decl header.

nameser.h also includes some fn protos.

But in any case, I don't see ftp, name service, or telnet as protocols
likely implemented directly by the boot blocks (or other standalone
programs) or the kernel.

So, don't put them in the kernel.


cgd
-- 
Chris Demetriou - cgd@netbsd.org - http://www.netbsd.org/People/Pages/cgd.html
Disclaimer: Not speaking for NetBSD, just expressing my own opinion.