Subject: port-arm32/12120: arm32 wdc drivers should use wdc_print_modes for a bit more info
To: None <gnats-bugs@gnats.netbsd.org>
From: None <chris@paradox.demon.co.uk>
List: netbsd-bugs
Date: 02/03/2001 05:57:23
>Number:         12120
>Category:       port-arm32
>Synopsis:       arm32 wdc drivers should use wdc_print_modes for a bit more info
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    port-arm32-maintainer
>State:          open
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Sat Feb 03 06:00:00 PST 2001
>Closed-Date:
>Last-Modified:
>Originator:     
>Release:        02-02-2001
>Organization:
>Environment:
System: NetBSD pinky.paradox.demon.co.uk 1.5R NetBSD 1.5R (PINKY2) #10: Fri Feb 2 23:47:51 GMT 2001 chris@pinky.paradox.demon.co.uk:/usr/src/src/sys/arch/i386/compile/PINKY2 i386
Architecture: i386
Machine: i386
>Description:
	When booting the arm32 kernels do not output what mode the wdc device is running the channels/devices in.  We should use the newish wdc_print_modes call
>How-To-Repeat:
	Boot a kernel/check dmesg and note the lack of info on what mode wdc is running in.
>Fix:
Index: sys/arch/arm32/mainbus/wdc_pioc.c
===================================================================
RCS file: /usr/src/local.cvs/netbsd/sys/arch/arm32/mainbus/wdc_pioc.c,v
retrieving revision 1.1.1.1
diff -u -p -r1.1.1.1 wdc_pioc.c
--- sys/arch/arm32/mainbus/wdc_pioc.c	2000/12/08 22:13:37	1.1.1.1
+++ sys/arch/arm32/mainbus/wdc_pioc.c	2001/01/25 00:40:55
@@ -166,6 +166,7 @@ wdc_pioc_attach(parent, self, aux)
 		return;
 	}
 	wdcattach(&sc->wdc_channel);
+	wdc_print_modes(&sc->wdc_channel);
 }
 
 /* End of wdc_pioc.c */
Index: sys/arch/arm32/podulebus/icside.c
===================================================================
RCS file: /usr/src/local.cvs/netbsd/sys/arch/arm32/podulebus/icside.c,v
retrieving revision 1.1.1.1
diff -u -p -r1.1.1.1 icside.c
--- sys/arch/arm32/podulebus/icside.c	2000/12/08 22:13:38	1.1.1.1
+++ sys/arch/arm32/podulebus/icside.c	2001/01/25 00:44:04
@@ -284,6 +284,7 @@ icside_attach(parent, self, aux)
 		(void)bus_space_read_1(iot, icp->ic_irqioh, 0);
 		/* Call common attach routines */
 		wdcattach(cp);
+		wdc_print_modes(cp);
 		/* Disable interrupts */
 		(void)bus_space_read_1(iot, icp->ic_irqioh, 0);
 		pa->pa_podule->irq_addr = iobase + ide->irqstatregs[channel];
Index: sys/arch/arm32/podulebus/rapide.c
===================================================================
RCS file: /usr/src/local.cvs/netbsd/sys/arch/arm32/podulebus/rapide.c,v
retrieving revision 1.1.1.1
diff -u -p -r1.1.1.1 rapide.c
--- sys/arch/arm32/podulebus/rapide.c	2000/12/08 22:13:38	1.1.1.1
+++ sys/arch/arm32/podulebus/rapide.c	2001/01/25 00:41:11
@@ -289,6 +289,7 @@ rapide_attach(parent, self, aux)
 		    sc->sc_intr_enable_mask);
 		/* XXX - Issue 1 cards will need to clear any pending interrupts */
 		wdcattach(cp);
+		wdc_print_modes(cp);
 		ihp = &rcp->rc_ih;
 		ihp->ih_func = rapide_intr;
 		ihp->ih_arg = rcp;
Index: sys/arch/arm32/podulebus/simide.c
===================================================================
RCS file: /usr/src/local.cvs/netbsd/sys/arch/arm32/podulebus/simide.c,v
retrieving revision 1.1.1.1
diff -u -p -r1.1.1.1 simide.c
--- sys/arch/arm32/podulebus/simide.c	2000/12/08 22:13:39	1.1.1.1
+++ sys/arch/arm32/podulebus/simide.c	2001/01/25 00:44:21
@@ -278,6 +278,7 @@ simide_attach(parent, self, aux)
 		bus_space_write_1(sc->sc_ctliot, sc->sc_ctlioh,
 		    CONTROL_REGISTER_OFFSET, sc->sc_ctl_reg);
 		wdcattach(cp);
+		wdc_print_modes(cp);
 		ihp = &scp->sc_ih;
 		ihp->ih_func = simide_intr;
 		ihp->ih_arg = scp;
>Release-Note:
>Audit-Trail:
>Unformatted: