Subject: lib/11624: "make cleandir dependall" fails in src/lib/libhdb
To: None <gnats-bugs@gnats.netbsd.org>
From: Greg A. Woods <woods@weird.com>
List: netbsd-bugs
Date: 12/02/2000 22:03:15
>Number:         11624
>Category:       lib
>Synopsis:       "make cleandir dependall" fails in src/lib/libhdb
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    lib-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Dec 02 22:03:00 PST 2000
>Closed-Date:
>Last-Modified:
>Originator:     Greg A. Woods
>Release:        2000/12/01
>Organization:
Planix, Inc.; Toronto, Ontario; Canada
>Environment:

	src/lib/libhdb/Makefile: 1.4

>Description:

	seems there's a missing dependency in src/lib/libhdb/Makefile
	-- a "make cleandir dependall" fails due to a generated header
	not being generated before the mkdep (this would normally not
	be an issue during a full "make build" because "make includes"
	successfully generates the missing header beforehand)

	note there also seems to be a duplicated hard-coded dependency
	line, and I think there's a little too much of the build
	process hidden from the user....

>How-To-Repeat:

	cd src/lib/libhdb
	make cleandir
	make dependall

>Fix:

	apply the following patch:

Index: Makefile
===================================================================
RCS file: /cvs/NetBSD/src/lib/libhdb/Makefile,v
retrieving revision 1.1.1.1
diff -c -c -r1.1.1.1 Makefile
*** Makefile	2000/09/22 04:15:52	1.1.1.1
--- Makefile	2000/12/03 05:49:47
***************
*** 16,22 ****
  
  gen_files = asn1_Key.x asn1_Event.x asn1_HDBFlags.x asn1_hdb_entry.x asn1_Salt.x
  
! DPSRCS=	hdb_err.h
  
  BUILT_SOURCES = $(gen_files:.x=.c) hdb_err.c
  
--- 16,22 ----
  
  gen_files = asn1_Key.x asn1_Event.x asn1_HDBFlags.x asn1_hdb_entry.x asn1_Salt.x
  
! DPSRCS=	hdb_err.h hdb_asn1.h
  
  BUILT_SOURCES = $(gen_files:.x=.c) hdb_err.c
  
***************
*** 36,43 ****
  
  INCSDIR= /usr/include/krb5
  
- $(gen_files) asn1.h: asn1_files
- 
  ASN1COMPILE!=	cd ${.CURDIR}/../libasn1/asn1_compile && ${MAKE} print-objdir
  
  asn1_files: hdb.asn1
--- 36,41 ----
***************
*** 72,79 ****
  .SUFFIXES: .hx .x
  
  .x.c:
! 	@cmp -s $< $@ 2> /dev/null || cp $< $@
  
  .hx.h:
! 	@cmp -s $< $@ 2> /dev/null || cp $< $@
! 
--- 70,76 ----
  .SUFFIXES: .hx .x
  
  .x.c:
! 	@cmp -s $< $@ 2> /dev/null || { echo cp $< $@ ; cp $< $@ ; }
  
  .hx.h:
! 	@cmp -s $< $@ 2> /dev/null || { echo cp $< $@ ; cp $< $@ ; }
>Release-Note:
>Audit-Trail:
>Unformatted: