Subject: pkg/11462: A sentence in any package's README.html is missing a period
To: None <gnats-bugs@gnats.netbsd.org>
From: Jeremy C. Reed <reed@reedmedia.net>
List: netbsd-bugs
Date: 11/09/2000 15:31:13
>Number:         11462
>Category:       pkg
>Synopsis:       formatting for current source version is removed
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Thu Nov 09 15:31:00 PST 2000
>Closed-Date:
>Last-Modified:
>Originator:     Jeremy C. Reed
>Release:        
>Organization:
	
>Environment:
	
System: NetBSD rainier 1.5_BETA NetBSD 1.5_BETA (GENERIC) #1: Sat Oct 21 13:59:18 MEST 2000 fvdl@sushi:/work/trees/netbsd-1-5/sys/arch/i386/compile/GENERIC i386


>Description:
A README.html page (using links as an example) has:

   The package is located in the "www/links" directory. The current source
   version of the package is links-0.92 For a summary on how to use the
   package collection, go to the top of the packages tree.

Notice how there is no "quotes" around the "links-0.92" and no period
at the end of that sentence.

There should be quotes (as defined in the README.pkg template). Also the
template is missing the period. Adding the period doesn't work, because
the make routine for README.html use a sed routine that that "reads" a file
which inserts to the next line.

>How-To-Repeat:
	
>Fix:

As far as I can tell, I see know purpose for putting the source package
name in a file and then reading it. 
Here is my diff: 

2843d2842
<       @${ECHO} '${PKGNAME:S/&/\&amp;/g:S/>/\&gt;/g:S/</\&lt;/g}' >> $@.tmp3
2851,2852c2850
<               -e '/%%PKG%%/r $@.tmp3'                                 \
<               -e '/%%PKG%%/d'                                         \
---
>               -e 's|%%PKG%%|${PKGNAME:S/&/\&amp;/g:S/>/\&gt;/g:S/</\&lt;/g}|g'\
2871c2869
<       @${RM} -f $@.tmp $@.tmp1 $@.tmp2 $@.tmp3 $@.tmp4 $@.tmp5 $@.tmp6
---
>       @${RM} -f $@.tmp $@.tmp1 $@.tmp2 $@.tmp4 $@.tmp5 $@.tmp6

On a side note, maybe the html checking/substitution isn't needed.
Do package names ever have ">", "<" or ampersands in them?

>Release-Note:
>Audit-Trail:
>Unformatted: