Subject: Re: bin/11072: usermod(8) mixes things up badly
To: None <feyrer@feyrer.de>
From: Alistair Crooks <AlistairCrooks@excite.com>
List: netbsd-bugs
Date: 09/25/2000 06:54:31
--19724563.969890071889.JavaMail.imail.prickles
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit

OK, spot the pasto:

In line 865 of src/usr.sbin/user/user.c, change the up->u_comment reference
to be up->u_shell (I've attached the full unified diff to this message).

This fixes the reported problem for me - now onto 11071.

Regards,
Alistair


--
Alistair Crooks (agc@pkgsrc.org)





_______________________________________________________
Say Bye to Slow Internet!
http://www.home.com/xinbox/signup.html

--19724563.969890071889.JavaMail.imail.prickles
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename=a

--- user.c	2000/09/25 13:38:08	1.1
+++ user.c	2000/09/25 13:52:26
@@ -862,7 +862,7 @@
 			memsave(&up->u_comment, pwp->pw_gecos, strlen(pwp->pw_gecos));
 		}
 		if (strcmp(up->u_shell, DEF_SHELL) == 0 && strcmp(pwp->pw_shell, DEF_SHELL) != 0) {
-			memsave(&up->u_comment, pwp->pw_shell, strlen(pwp->pw_shell));
+			memsave(&up->u_shell, pwp->pw_shell, strlen(pwp->pw_shell));
 		}
 	}
 	loginc = strlen(login);

--19724563.969890071889.JavaMail.imail.prickles--