>Number:         11004
>Category:       bin
>Synopsis:       skey segfaults when passed passphrase on command line
>Confidential:   no
>Severity:       critical
>Priority:       high
>Responsible:    bin-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Sep 13 08:37:01 PDT 2000
>Closed-Date:
>Last-Modified:
>Originator:     TheMan
>Release:        20000825
>Organization:
NetBSD 1.5E (RESTON) #25: Fri Aug 18 17:27:29 EDT 2000

Remember...Ebola is a river in Africa.
>Environment:
	
System: NetBSD ebola 1.5E NetBSD 1.5E (RESTON) #25: Fri Aug 18 17:27:29 EDT 2000 andrew@ebola:/usr/src/sys/arch/i386/compile/RESTON i386


>Description:

	skey seg faults when passed the pass phrase via the command line.
	i realize mjl may have been trying to "discourage" this particular
	use of skey, but i think it's just a thinko.

>How-To-Repeat:

	skey -p foo

>Fix:

--- skey.c-orig	Tue Jul 25 12:47:09 2000
+++ skey.c	Wed Sep 13 11:31:10 2000
@@ -53,7 +53,7 @@
 			cnt = atoi(optarg);
 			break;
 		case 'p':
-			if (strlcpy(passwd, argv[++i], sizeof(passwd)) >=
+			if (strlcpy(passwd, optarg, sizeof(passwd)) >=
 							sizeof(passwd))
 				errx(1, "Password too long");
 			pass = 1;
>Release-Note:
>Audit-Trail:
>Unformatted: