Subject: kern/9570: ddb prints spurrious newlines
To: None <gnats-bugs@gnats.netbsd.org>
From: John Hawkinson <jhawk@mit.edu>
List: netbsd-bugs
Date: 03/07/2000 23:57:33
>Number: 9570
>Category: kern
>Synopsis: ddb prints spurrious newlines
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: kern-bug-people (Kernel Bug People)
>State: open
>Class: sw-bug
>Submitter-Id: net
>Arrival-Date: Tue Mar 7 23:57:00 2000
>Last-Modified:
>Originator: John Hawkinson
>Organization:
MIT
>Release: NetBSD 1.4.1
>Environment:
System: NetBSD zorkmid.mit.edu 1.4.1 NetBSD 1.4.1 (ZORKMID) #59: Wed Mar 8 02:08:10 EST 2000 jhawk@zorkmid.mit.edu:/usr/src/sys/arch/i386/compile/ZORKMID i386
>Description:
ddb sometimes prints two newlines if it tries to write to
the 80th column of the screen. This is evident in some stack
traces.
>How-To-Repeat:
Use 't' a lot. Sorry, still no serial console and the inclination
to write down these cases longhand and transcribe them is not
present.
>Fix:
===================================================================
RCS file: sys/ddb/RCS/db_output.c,v
retrieving revision 1.1
retrieving revision 1.2
diff -c -r1.1 -r1.2
*** sys/ddb/db_output.c 2000/03/08 03:25:16 1.1
--- sys/ddb/db_output.c 2000/03/08 07:27:13 1.2
***************
*** 151,157 ****
cnputc(c);
db_output_position++;
if (db_max_width >= DB_MIN_MAX_WIDTH
! && db_output_position >= db_max_width-1) {
/* auto new line */
cnputc('\n');
db_output_position = 0;
--- 151,157 ----
cnputc(c);
db_output_position++;
if (db_max_width >= DB_MIN_MAX_WIDTH
! && db_output_position >= db_max_width) {
/* auto new line */
cnputc('\n');
db_output_position = 0;
>Audit-Trail:
>Unformatted: