Subject: port-hp300/9388: hp300 kernel build error
To: None <gnats-bugs@gnats.netbsd.org>
From: None <swp@alumni.rice.edu>
List: netbsd-bugs
Date: 02/10/2000 08:33:45
>Number:         9388
>Category:       port-hp300
>Synopsis:       Kernel build on hp300 fails with 2000/02/08 sources
>Confidential:   no
>Severity:       critical
>Priority:       high
>Responsible:    port-hp300-maintainer (NetBSD/hp300 Portmaster)
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Feb 10 08:33:00 2000
>Last-Modified:
>Originator:     Steve Peurifoy
>Organization:
>Release:        NetBSD-current 2000/02/08
>Environment:
 System: NetBSD loop 1.4P NetBSD 1.4P (loop) #0: Sat Jan 15 18:37:10 MST 2000 root@loop:/usr/src/sys/arch/hp300/compile/loop hp300


>Description:
	There is a printf() format specifier of %ld in sdintr() in the
	file src/sys/arch/hp300/dev/sd.c which is used to print the
	retry count.  The recent changes related to ordered writes
	changed the variable being printed to an int.
>How-To-Repeat:
	Build a kernel including the sd device.
>Fix:

Index: sd.c
===================================================================
RCS file: /cvs/src/sys/arch/hp300/dev/sd.c,v
retrieving revision 1.13
diff -c -r1.13 sd.c
*** sd.c	2000/02/10 03:26:47	1.13
--- sd.c	2000/02/10 16:11:25
***************
*** 1040,1046 ****
  		cond = sderror(sc, stat);
  		if (cond) {
  			if (cond < 0 && sc->sc_errcnt++ < SDRETRY) {
! 				printf("%s: retry #%ld\n",
  				    sc->sc_dev.dv_xname,
  				    sc->sc_errcnt);
  				sdstart(sc);
--- 1040,1046 ----
  		cond = sderror(sc, stat);
  		if (cond) {
  			if (cond < 0 && sc->sc_errcnt++ < SDRETRY) {
! 				printf("%s: retry #%d\n",
  				    sc->sc_dev.dv_xname,
  				    sc->sc_errcnt);
  				sdstart(sc);

>Audit-Trail:
>Unformatted: