Subject: xsrc/9348: xsrc/Makefile makes bogus assumption about BSDSRCDIR
To: None <>
From: None <>
List: netbsd-bugs
Date: 02/04/2000 07:48:44
>Number:         9348
>Category:       xsrc
>Synopsis:       xsrc/Makefile makes bogus assumption about BSDSRCDIR
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    xsrc-manager (NetBSD X11 bug manager)
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Feb  4 07:48:01 2000
>Originator:     Jim Bernard
	Speaking for myself
>Release:        February 3, 2000
System: NetBSD nool 1.4R NetBSD 1.4R (NOOL-$Revision: 1.6 $) #0: Thu Feb 3 08:50:33 MST 2000 jbernard@nool:/home/tmp/compile/sys/arch/i386/compile/NOOL i386

	The xsrc Makefile purports to support specification of an arbitrary
	location for the main bsd source tree, as it needs to find the
	distrib/sets subdirectory of that tree.  However, it contains one
	assumed path to the source directory.

	Try to build an X snapshot using a non-default arrangement of
	directories, with BSDSRCDIR appropriately set; note that the
	construction of the release sets fails because:

	  ../src/distrib/sets/makeflist: Can't open ../src/distrib/sets/makeflist

	Note that the Makefile contains an explicit reference to
	../src/distrib/sets that is the source of the difficulty.

	Replace "../src" by ${BSDSRCDIR}, and all will be well:

--- Makefile-dist	Wed Dec 29 05:52:14 1999
+++ Makefile	Fri Feb  4 08:34:31 2000
@@ -90,11 +90,11 @@
 release snapshot: build
 	${INSTALL} -d -m 755 -o root -g wheel ${RELEASEDIR}/binary/sets
-	sh ${BSDSRCDIR}/distrib/sets/maketars -x -s ../src/distrib/sets \
+	sh ${BSDSRCDIR}/distrib/sets/maketars -x -s ${BSDSRCDIR}/distrib/sets \
 		-d ${DESTDIR} -t ${RELEASEDIR}/binary/sets
 	cd ${RELEASEDIR}/binary/sets && \
 		cksum -o 1 *.tgz >BSDSUM && \
 		cksum *.tgz >CKSUM && \
 		cksum -m *.tgz >MD5 && \