Subject: pkg/8558: Mutt 0.95.7 fails to lock certain mailboxes, marking them read-only incorrectly.
To: None <gnats-bugs@gnats.netbsd.org>
From: Jeroen Scheerder <J.Scheerder@cwi.nl>
List: netbsd-bugs
Date: 10/05/1999 05:06:01
>Number:         8558
>Category:       pkg
>Synopsis:       Mutt 0.95.7 fails to lock certain mailboxes, marking them read-only incorrectly.
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager (NetBSD software packages system bug manager)
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Oct  5 05:05:01 1999
>Last-Modified:
>Originator:     Jeroen Scheerder
>Organization:
>Release:        NetBSD-1.4.1
>Environment:
>Description:
Mutt is configured to use both fcntl and dotlocking.  Even when fcntl succeeds,
dotlocking is attempted -- and fails, typically, on nfs-mounted mailboxes.

>How-To-Repeat:
Use an NFS-mounted mailspool.  Enter mutt, hit `%', and voila.

>Fix:
The (or rather, a) fix is to make locking succeed after a successful fcntl
lock (rather than have the dotlock lock again, and possibly fail).
The following patch to mutt-0.95.7-us/mx.c is all it takes.

*** mx.c.org    Tue Oct  5 13:04:27 1999
--- mx.c        Tue Oct  5 13:04:30 1999
***************
*** 188,193 ****
--- 188,194 ----
      mutt_message (_("Waiting for fcntl lock... %d"), ++attempt);
      sleep (1);
    }
+   r = 1;
  #endif /* USE_FCNTL */
  
  #ifdef USE_FLOCK
>Audit-Trail:
>Unformatted:


NetBSD-1.4.1
System: NetBSD dek 1.4.1 NetBSD 1.4.1 (JS) #1: Fri Sep 17 12:56:09 MEST 1999 js@dek:/usr/src/sys/arch/i386/compile/JS i386