Subject: bin/8475: usr.bin/col getopt fails (bad patch 1.9->1.10)
To: None <gnats-bugs@gnats.netbsd.org>
From: None <mason@primenet.com.au>
List: netbsd-bugs
Date: 09/22/1999 21:56:56
>Number:         8475
>Category:       bin
>Synopsis:       getopt for usr.bin/col is incorrect
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    bin-bug-people (Utility Bug People)
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Sep 22 21:05:00 1999
>Last-Modified:
>Originator:     Geoff C. Wing
>Organization:
Geoff Wing : <gcw@pobox.com>     Work URL: http://www.primenet.com.au/
Rxvt Stuff : <gcw@rxvt.org>      Ego URL : http://pobox.com/~gcw/
Zsh Stuff  : <gcw@zsh.org>       Phone   : (Australia) 0413 431 874
>Release:        After 19990222
>Environment:
System: NetBSD c.primenet.com.au 1.4K NetBSD 1.4K (C) #0: Mon Sep 20 17:21:41 EST 1999 open@rubicon.stables.primenet.com.au:/usr/netbsd/src/sys/arch/i386/compile/C i386


>Description:
	patch 1.9->1.10 for usr.bin/col/col.c killed the getopt line

	% col -l <argument>
	% col -p # noargument

>How-To-Repeat:
	% col -l 20
	seg fault
>Fix:

*** usr.bin/col/col.c.org	Tue Feb 23 09:16:01 1999
--- usr.bin/col/col.c	Thu Sep 23 13:55:32 1999
***************
*** 137,143 ****
  	max_bufd_lines = 128;
  	compress_spaces = 1;		/* compress spaces into tabs */
  	pass_unknown_seqs = 0;		/* remove unknown escape sequences */
! 	while ((opt = getopt(argc, argv, "bfhlp:x")) != -1)
  		switch (opt) {
  		case 'b':		/* do not output backspaces */
  			no_backspaces = 1;
--- 137,143 ----
  	max_bufd_lines = 128;
  	compress_spaces = 1;		/* compress spaces into tabs */
  	pass_unknown_seqs = 0;		/* remove unknown escape sequences */
! 	while ((opt = getopt(argc, argv, "bfhl:px")) != -1)
  		switch (opt) {
  		case 'b':		/* do not output backspaces */
  			no_backspaces = 1;
>Audit-Trail:
>Unformatted: