>Number:         8143
>Category:       pkg
>Synopsis:       package games/craft won't build on NetBSD 1.4/arm32
>Confidential:   no
>Severity:       critical
>Priority:       medium
>Responsible:    pkg-manager (NetBSD software packages system bug manager)
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Aug  4 06:20:00 1999
>Last-Modified:
>Originator:     Reinoud Zandijk
>Organization:
Twente University
	
>Release:        NetBSD-release fetched at 2 aug <NetBSD-current source date>
>Environment:
	
System: NetBSD ismaelda 1.4.1 NetBSD 1.4.1 (config.ismaelda) #3: Mon Aug 2 17:35:14 CEST 1999 root@ismaelda:/usr/src/sys/arch/arm32/compile/config.ismaelda arm32


>Description:
The game `craft' won't build on arm32 due to assumption made by the origional author that a `char' is signed by default. Patching this makes the program compile and running OK.
The symptoms were multiple warnings about comparisations always resulting in true/false...

	
>How-To-Repeat:
Build the distribution of games/craft on NetBSD/arm32; it fails.
	
>Fix:
Use the following patches (patch-ag updated) :

/usr/pkgsrc/games/craft/patches/patch-ag :

"
--- hcc/hcc.cc.orig	Fri Feb 21 12:50:16 1997
+++ hcc/hcc.cc	Wed Aug  4 15:37:39 1999
@@ -1,6 +1,5 @@
-#include "bool.h"
 #include "stdio.h"
-#include "std.h"
+#include <stdlib.h>
 #include "string.h"
 #include "ctype.h"
 
@@ -203,7 +202,7 @@
    char last_last_sym;
    int  last_ref_sym_line;
    int  last_ref_sym_no;
-   char sym;
+   signed char sym;
    int  nested_brackets;
    bool inside_refinement;
    bool inside_string;
"

/usr/pkgsrc/games/craft/patches/patch-ah :

"
--- xfile.hc.orig	Thu Mar 20 09:29:16 1997
+++ xfile.hc	Wed Aug  4 14:42:46 1999
@@ -12,10 +12,10 @@
 /*----------------------------------------------------------------------*/
 
 struct conv 
-   {char b0; 
-    char b1;
-    char b2;
-    char b3;
+   {signed char b0; 
+    signed char b1;
+    signed char b2;
+    signed char b3;
    };
 
 union conv_data
"

end of patches/pr.

>Audit-Trail:
>Unformatted: