Subject: Re: port-macppc/7891: macppc lacks definition of _insque
To: Erik Bertelsen <erik@mediator.uni-c.dk>
From: Jason Thorpe <thorpej@nas.nasa.gov>
List: netbsd-bugs
Date: 07/01/1999 23:53:17
On Fri, 2 Jul 1999 07:43:28 +0200 
 Erik Bertelsen <erik@mediator.uni-c.dk> wrote:

 > > It's ... not at all clear that new code should be using insque/remque.
 > > 
 > > 
 > > 
 > > cgd
 > 
 > If this is the case, I'd better tell more about the exact message to help
 > locate the insque/remque calls:

This is probably a remnant of the code also running in BSD/OS, which still
uses insque/remque for PCB housekeeping.

NetBSD replaced this will TAILQ/LIST stuff quite some time ago.  I suspect
it won't be hard to fix.

 > sh ../../../../conf/newvers.sh
 > cc  -O2 -pipe -Werror -Wreturn-type -Wpointer-arith -Wno-main -msoft-float -I. -I../../../../arch -I../../../.. -nostdinc -DDIAGNOSTIC -DTRAP_PANICWAIT -DINET6 -DIPSEC -DMAXUSERS=32 -D_KERNEL -Dmacppc  -c vers.c
 > rm -f netbsd
 > ld -N -Ttext 100000 -e __start -x -o netbsd ${SYSTEM_OBJ} vers.o
 > in6_pcb.o: In function `in6_pcballoc':
 > in6_pcb.o(.text+0x6c): undefined reference to `_insque'
 > in6_pcb.o: In function `in6_pcbdetach':
 > in6_pcb.o(.text+0xdf0): undefined reference to `_remque'
 > *** Error code 1

...and having just looked, it looks trivial to fix.  But, there are
other problem, too.  All of the IPv6 code uses the wrong spl calls.

splnet() is uses where splsoftnet() is required.  The splimp() is okay
for now (it's used as IPv4 uses it).

        -- Jason R. Thorpe <thorpej@nas.nasa.gov>