Subject: install/7864: sysinst (i386)
To: None <>
From: None <>
List: netbsd-bugs
Date: 06/27/1999 05:35:41
>Number:         7864
>Category:       install
>Synopsis:       msg_window is void, but main.c assumes int
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    install-manager (NetBSD system installation bug manager)
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Jun 27 05:35:00 1999
>Originator:     Patrick Welche
>Release:        Sat 26 Jun 1999 13:17 GMT sup
System: NetBSD 1.4D-current i386

cc -O2  -Wall -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Werror   -I. -I/usr/src/distrib/utils/sysinst/arch/i386/../.. -I/usr/src/distrib/utils/sysinst/arch/i386  -DREL=\"1.4D\" -DMACH=\"i386\" -c /usr/src/distrib/utils/sysinst/arch/i386/../../main.c
/usr/src/distrib/utils/sysinst/arch/i386/../../main.c: In function `main':
/usr/src/distrib/utils/sysinst/arch/i386/../../main.c:127: void value not ignored as it ought to be

        if (msg_window(win) != 0) {

The only declaration of msg_window I can find is in arch/i386/msg_defs.h:
void msg_window(WINDOW *window);

What do other archs do?
Unsure, especially given comment in main.c just before:

         * XXX the following is bogus.  if screen is too small, message
         * XXX window will be overwritten by menus.

I'm just changing the routine in arch/i386/msg_defs.c to

int msg_window(WINDOW *window)
        msg_win = window;
	return 0;

with corresponding change in msg_defs.h