Subject: kern/6801: MD machdep files using sys/mtio.h for no reason
To: None <gnats-bugs@gnats.netbsd.org>
From: Erik E. Fair <fair@digital.clock.org>
List: netbsd-bugs
Date: 01/13/1999 11:18:44
>Number:         6801
>Category:       kern
>Synopsis:       MD machdep files using sys/mtio.h for no reason
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    kern-bug-people (Kernel Bug People)
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Jan 13 11:35:01 1999
>Last-Modified:
>Originator:     Erik E. Fair
>Organization:
International Organization of Internet Clock Watchers
>Release:        NetBSD-current 19990113
>Environment:
	
System: NetBSD digital.clock.org 1.3 NetBSD 1.3 (DIGITAL) #1: Mon May 25 14:16:49 PDT 1998 fair@digital.clock.org:/usr/src/sys/arch/sparc/compile/DIGITAL sparc


>Description:
	Kernel source files should only #include what they need.

	The following files #include <sys/mtio.h> without referencing
	any of its contents:

		src/sys/arch/amiga/amiga/sys_machdep.c
		src/sys/arch/atari/atari/sys_machdep.c
		src/sys/arch/hp300/hp300/sys_machdep.c
		src/sys/arch/i386/i386/sys_machdep.c
		src/sys/arch/mac68k/mac68k/sys_machdep.c
		src/sys/arch/mips/mips/sys_machdep.c
		src/sys/arch/mvme68k/mvme68k/sys_machdep.c
		src/sys/arch/next68k/next68k/sys_machdep.c
		src/sys/arch/pc532/pc532/sys_machdep.c
		src/sys/arch/pica/pica/sys_machdep.c
		src/sys/arch/sparc/sparc/sys_machdep.c
		src/sys/arch/sparc64/sparc64/sys_machdep.c
		src/sys/arch/sun3/sun3/sys_machdep.c
		src/sys/arch/x68k/x68k/sys_machdep.c

	Why would any of these need tape I/O ioctl's? 
>How-To-Repeat:
	Code inspection.
>Fix:
	Remove the #include directives.
>Audit-Trail:
>Unformatted: