Subject: bin/5440: In src/usr.bin/strip/Makefile, make install ignores $STRIP
To: None <gnats-bugs@gnats.netbsd.org>
From: None <jewell@mit.edu>
List: netbsd-bugs
Date: 05/11/1998 06:30:36
>Number:         5440
>Category:       bin
>Synopsis:       In src/usr.bin/strip/Makefile, make install ignores $STRIP
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    bin-bug-people (Utility Bug People)
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon May 11 03:35:01 1998
>Last-Modified:
>Originator:     Darrin B. Jewell
>Organization:
Unorganized
	
>Release:        1.3E, -current last updated 19980506 ~2020 EDT
>Environment:
	
System: NetBSD second-sally.sport-death.org 1.3E NetBSD 1.3E (SECOND-SALLY) #3: Thu May 7 05:59:49 EDT 1998 jewell@second-sally.sport-death.org:/u1/SECOND-SALLY i386


>Description:
    make install in /usr/src/usr.bin/strip ignores $STRIP
    and instead invokes ./strip.  This breaks cross compiles.

	
>How-To-Repeat:
  I first experienced this problem while doing a cross compile,
  and install, but the following typescript demonstrates the
  unexpected behavior:

    Script started on Mon May 11 06:16:09 1998
    # cd /usr/src/usr.bin/strip
    # STRIP=/usr/bin/wall
    # export STRIP
    # make install
    install -c -o root -g wheel -m 600 strip /usr/bin/strip
    if [ "-s" != "" ]; then ./strip /usr/bin/strip; fi
    chmod 555 /usr/bin/strip
    if [ "-c" = "" ]; then rm -f ./strip; fi
    gzip -cf /usr/src/usr.bin/strip/strip.1 > /usr/share/man/man1/strip.1.gz
    gzip -cf strip.cat1 > /usr/share/man/cat1/strip.0.gz
    # exit
    Script done on Mon May 11 06:16:36 1998

Notice that ./strip was invoked instead of /usr/bin/wall.
When doing a cross compile, ./strip is an invalid program to execute.
	
>Fix:
  use ${STRIP} instead of ./strip,
  This may cause a problem with strip trying to strip itself,
  which will probably also have to be checked for and worked around.
	
>Audit-Trail:
>Unformatted: