Subject: port-i386/5000: recent change to sbdsp.c broke playing audio properly on dsp v3.02
To: None <gnats-bugs@gnats.netbsd.org>
From: None <frueauf@ira.uka.de>
List: netbsd-bugs
Date: 02/16/1998 12:39:53
>Number:         5000
>Category:       port-i386
>Synopsis:       recent change to sbdsp.c broke playing audio properly on dsp v3.02
>Confidential:   no
>Severity:       critical
>Priority:       high
>Responsible:    gnats-admin (GNATS administrator)
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Feb 16 03:50:00 1998
>Last-Modified:
>Originator:     Thorsten Frueauf
>Organization:
private
	
>Release:        <NetBSD-current source date> NetBSD-current from 15.2.1998
>Environment:
	
NetBSD cyberlap 1.3C NetBSD 1.3C (CYBERLAP) #4: Mon Feb 16 12:22:02 MET 1998     frueauf@cyberlap:/src/sys/arch/i386/compile/CYBERLAP i386

Toshiba Tecra 500 CDT laptop (with Chrystal sound CS4232 chip)

sb0 at isa0 port 0x220-0x237 irq 5 drq 1: dsp v3.02
audio0 at sb0

>Description:
	
The recent change to sbdsp.c:

--- snip ---
--- sbdsp.c     Mon Feb 16 12:21:36 1998
+++ sbdsp.c-1.78        Sun Feb  1 12:19:03 1998
@@ -1,4 +1,4 @@
-/*     $NetBSD: sbdsp.c,v 1.77 1997/12/02 13:17:39 mycroft Exp $       */
+/*     $NetBSD: sbdsp.c,v 1.78 1998/01/30 11:55:36 bouyer Exp $        */
 
 /*
  * Copyright (c) 1991-1993 Regents of the University of California.
@@ -1071,11 +1071,14 @@
 #else
                sc->sc_mixer_model = SBM_CT1745;
 #endif
+#if 0
+/* XXX figure out a good way of determining the model */
                /* XXX what about SB_32 */
                if (SBVER_MINOR(v) == 16)
                        sc->sc_model = SB_64;
                else
-                       sc->sc_model = SB_16;
+#endif
+               sc->sc_model = SB_16;
                break;
        }
 }
--- snip ---

broke playing audio files via e.g. xanim on my laptop. If I revert this
change, sound plays like normal. With above change, it plays random pieces
from the sound in random order (no longer fiting to the played anim).

>How-To-Repeat:
	
Try xanim on above machine and agree that the sound is not like normal.

>Fix:
	
Revert the change to sbdsp.c or find a better solution.
>Audit-Trail:
>Unformatted:
recent change to sbdsp.c broke playing audio properly on dsp v3.02