Subject: pkg/4878: rplay's Makefile has some errors
To: None <gnats-bugs@gnats.netbsd.org>
From: Manuel Bouyer <bouyer@antioche.lip6.fr>
List: netbsd-bugs
Date: 01/23/1998 16:59:42
>Number:         4878
>Category:       pkg
>Synopsis:       rplay's Makefile has some errors
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    gnats-admin (GNATS administrator)
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Jan 23 08:05:01 1998
>Last-Modified:
>Originator:     bouyer@antioche.lip6.fr (Manuel Bouyer)
>Organization:

LIP6, Universite Paris VI.

>Release:        NetBSD 1.3
>Environment:

	Stock NetBSD 1.3/i386, pkgsrc supped yesterday.

>Description:
	Rplay's Makefile has some error:
	- it doesn't depend on install-info
	- it doens't find gsm lib and includes if it's not installed in /usr/local.

>How-To-Repeat:
	'make' in audio/rplay, without gtextinfo installed, and a prefix different
	from /usr/local (e.g /usr/pkg).
>Fix:

I'm not sure this is the rigth solution, I let the package gurus adapt this.
Setting CFLAGS and LDFLAGS is suggested by the configure script when it can't
find some libraries.
	
--- /mnt/pub/NetBSD/NetBSD-current/pkgsrc/audio/rplay/Makefile	Mon Jan 19 13:44:26 1998
+++ Makefile	Fri Jan 23 16:33:16 1998
@@ -14,9 +14,13 @@
 MAINTAINER=	rmallory@csusb.edu
 
 LIB_DEPENDS=    gsm\\.1\\.0:${PORTSDIR}/audio/gsm
+BUILD_DEPENDS=  install-info:${PORTSDIR}/devel/gtexinfo
 
 HAS_CONFIGURE=	yes
-CONFIGURE_ENV+=	RPLAY_TARGET=generic	# XXX
+CONFIGURE_ARGS= "--prefix=$(PREFIX)"
+CONFIGURE_ENV+=	RPLAY_TARGET=generic # XXX
+CONFIGURE_ENV+=	CFLAGS=-I$(PREFIX)/include # XXX
+CONFIGURE_ENV+=	LDFLAGS=-L$(PREFIX)/lib # XXX
 #USE_GMAKE=	yes
 MAN1=           rplay.1 xrplay.1 rplayd.1 rptp.1
 MAN5=		rplay.conf.5 rplay.hosts.5 rplay.servers.5
>Audit-Trail:
>Unformatted: