Subject: misc/4642: WWW PR query duplicates blank lines
To: None <gnats-bugs@gnats.netbsd.org>
From: Dave Huang <khym@bga.com>
List: netbsd-bugs
Date: 12/04/1997 23:59:34
>Number:         4642
>Category:       misc
>Synopsis:       WWW PR query duplicates blank lines
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    misc-bug-people (Misc Bug People)
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Dec  4 22:05:00 1997
>Last-Modified:
>Originator:     Dave Huang
>Organization:
>Release:        $NetBSD: query-full-pr,v 1.11 1996/06/14 19:52:51 thorpej Exp $
>Environment:
n/a
>Description:
	The WWW interface to the PR database at
http://www.netbsd.org/Misc/query-pr.html is very nice, but it does have an
annoying problem. Any blank lines in the original PR get turned into two
blank lines. This makes it difficult to use any patches that are included
in the PR.
>How-To-Repeat:
	Take a look at http://www.netbsd.org/cgi-bin/query-full-pr?4439
for example. Notice that all the blank lines come in pairs, and that while
the diff says the patch should be at +811,8, there are actually 9 lines in
the patch.

Try to use the patch:

# ftp http://www.netbsd.org/cgi-bin/query-full-pr\?4439
Requesting http://www.netbsd.org/cgi-bin/query-full-pr?4439
Successfully retrieved file.
# pwd
/usr/src/sys/miscfs/union
# patch < query-full-pr\?4439 
Hmm...  Looks like a unified diff to me...
The text leading up to this was:
--------------------------
 [ body of PR deleted ]
--------------------------
Patching file union_vnops.c using Plan A...
Hunk #1 succeeded at 772 with fuzz 2 (offset -39 lines).
Hmm...  Ignoring the trailing garbage.
done
# tail +773 union_vnops.c | head -10
        struct vattr va;


        va.va_nlink = 0;

        /*
         * Some programs walk the filesystem hierarchy by counting
         * links to directories to avoid stat'ing all the time.
         * This means the link count on directories needs to be "correct".
         * The only way to do that is to call getattr on both layers

Ack, that's not where the patch should go!

>Fix:
>Audit-Trail:
>Unformatted: