Subject: misc/4272: bugs in plan9 pkg
To: None <gnats-bugs@gnats.netbsd.org>
From: David D Golombek <daveg@mit.edu>
List: netbsd-bugs
Date: 10/14/1997 18:37:01
>Number:         4272
>Category:       misc
>Synopsis:       bugs in plan9 pkg
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    misc-bug-people (Misc Bug People)
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Oct 14 15:50:04 1997
>Last-Modified:
>Originator:     David D Golombek
>Organization:
DaveG
		MIT					ICE
Student, Programmer, Gymnast, Dancer____________Full-time Programmer
http://www.mit.edu/people/daveg/home.html_______http://www.iced.com
(617)225-6522___________________________________(888)ICE-THIS x1984
>Release:        pkgsrc of 10/14.97
>Environment:
	
System: NetBSD iced 1.2G NetBSD 1.2G (ICED) #2: Wed Sep 24 20:30:54 EDT 1997 daveg@iced:/u1/usr/src/sys/arch/i386/compile/ICED i386


>Description:
	There are a couple bugs in the handling of the plan9 package.
	First, the plan9 makefile builds 9term before sam, but 9term
	depends upon sam:
	# needs library and private header, but not during runtime
	BUILD_DEPENDS=	/always_build_it:${PORTSDIR}/plan9/sam
	Second, when installing 9wm, USE_IMAKE is specified, which
	tries to pull in /etc/mtree/BSD.local.dist which doesn't
	exist on NetBSD as far as I've ever seen.

>How-To-Repeat:
	pull pkgsrc/plan9 off the ftp site and try to build it as is.
	If it's a first time build, it should fail to build for
	the above reasons.
	
>Fix:
	For part 1, put SUBDIR += sam above SUBDIR += 9wm.

iced:/users/daveg/pkg/plan9 $diff -c Makefile.orig Makefile
*** Makefile.orig       Tue Oct 14 18:29:51 1997
--- Makefile    Tue Oct 14 18:29:57 1997
***************
*** 4,12 ****
  
      SUBDIR += 9menu
      SUBDIR += 9term
      SUBDIR += 9wm
      SUBDIR += Xg
-     SUBDIR += sam
      SUBDIR += rc
  
  .include <bsd.port.subdir.mk>
--- 4,12 ----
  
      SUBDIR += 9menu
      SUBDIR += 9term
+     SUBDIR += sam
      SUBDIR += 9wm
      SUBDIR += Xg
      SUBDIR += rc
  
  .include <bsd.port.subdir.mk>


	For part 2, I'm not sure of the correct fix.  It appears 
	/usr/share/mk/bsd.port.mk needs to be reordered when
	setting MTREE_FILE to check OPSYS == NetBSD before
	checking USE_IMAKE or USE_X11, but I'm familiar enough
	with the port makesystem to be certain.

iced:/users/daveg $diff -c bsd.port.mk.orig bsd.port.mk
*** bsd.port.mk.orig    Tue Oct 14 18:27:30 1997
--- bsd.port.mk Tue Oct 14 18:27:44 1997
***************
*** 442,452 ****
  
  # Figure out where the local mtree file is
  .if !defined(MTREE_FILE)
- .if defined(USE_IMAKE) || defined(USE_X11)
- MTREE_FILE=   /etc/mtree/BSD.x11.dist
- .else
  .if (${OPSYS} == "NetBSD")
  MTREE_FILE=   /etc/mtree/BSD.pkg.dist
  .else
  MTREE_FILE=   /etc/mtree/BSD.local.dist
  .endif
--- 442,452 ----
  
  # Figure out where the local mtree file is
  .if !defined(MTREE_FILE)
  .if (${OPSYS} == "NetBSD")
  MTREE_FILE=   /etc/mtree/BSD.pkg.dist
+ .else
+ .if defined(USE_IMAKE) || defined(USE_X11)
+ MTREE_FILE=   /etc/mtree/BSD.x11.dist
  .else
  MTREE_FILE=   /etc/mtree/BSD.local.dist
  .endif
>Audit-Trail:
>Unformatted: