>Number:         3906
>Category:       port-hp300
>Synopsis:       hp300/dev/rd.c uses stil HPIBBUS_PUNIT_UNK which was renamed
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    gnats-admin (GNATS administrator)
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Jul 22 07:50:01 1997
>Last-Modified:
>Originator:     Thorsten Frueauf
>Organization:
private
>Release:        <NetBSD-current source date> NetBSD current 20.07.1997
>Environment:
	
NetBSD cybersil 1.2G NetBSD 1.2G (CYBERSIL) #0: Thu Jul 10 15:54:22 MEST 1997     milano@cybersil:/usr/src/sys/arch/hp300/compile/CYBERSIL hp300


>Description:
	
hp300/dev/rd.c does not reflect the recent change of 
HPIBBUS_PUNIT_UNK -> HPIBBUSCF_PUNIT_DEFAULT.

>How-To-Repeat:
	
Compile a recent kernel on NetBSD/hp300 and watch:

cc  -O2 -Werror -Wall -Wstrict-prototypes -Wmissing-prototypes -msoft-float -I. -I../../../../arch -I../../../.. -nostdinc -DSWAPPAGER -DVNODEPAGER -DDEVPAGER -DEXEC_AOUT -DEXEC_SCRIPT -DCOMPAT_43 -DCOMPAT_44 -DCOMPAT_09 -DCOMPAT_10 -DCOMPAT_11 -DCOMPAT_12 -DSYSVSHM -DSYSVSEM -DSYSVMSG -DKTRACE -DNKMEMCLUSTERS="0x400" -DFFS -DCD9660 -DNFS -DUNION -DKERNFS -DFDESC -DPROCFS -DMFS -DFIFO -DQUOTA -DNFSSERVER -DINET -DTCP_COMPAT_42 -DFPSP -DCOMPAT_NOLABEL -DUK_KEYBOARD -DCOMPAT_HPUX -DCOMPAT_M68K4K -DMAXUSERS=32 -D_KERNEL  -Dmc68020 -Dhp300 -DFPCOPROC  -c ../../../../arch/hp300/dev/rd.c
../../../../arch/hp300/dev/rd.c: In function `rdmatch':
../../../../arch/hp300/dev/rd.c:262: `HPIBBUS_PUNIT_UNK' undeclared (first use this function)
../../../../arch/hp300/dev/rd.c:262: (Each undeclared identifier is reported only once
../../../../arch/hp300/dev/rd.c:262: for each function it appears in.)
*** Error code 1

>Fix:
	
Apply the following patch to /src/sys/arch/hp300/dev/rd.c:

*** rd.c-orig	Tue Jul 22 16:11:59 1997
--- rd.c	Tue Jul 22 16:11:59 1997
***************
*** 259,265 ****
  	 * Set punit if operator specified one in the kernel
  	 * configuration file.
  	 */
! 	if (match->hpibbuscf_punit != HPIBBUS_PUNIT_UNK &&
  	    match->hpibbuscf_punit < HPIB_NPUNITS)
  		ha->ha_punit = match->hpibbuscf_punit;
  
--- 259,265 ----
  	 * Set punit if operator specified one in the kernel
  	 * configuration file.
  	 */
! 	if (match->hpibbuscf_punit != HPIBBUSCF_PUNIT_DEFAULT &&
  	    match->hpibbuscf_punit < HPIB_NPUNITS)
  		ha->ha_punit = match->hpibbuscf_punit;
  
>Audit-Trail:
>Unformatted:
hp300/dev/rd.c uses stil HPIBBUS_PUNIT_UNK which was renamed