Subject: misc/3801: some documents are installed as executable
To: None <gnats-bugs@gnats.netbsd.org>
From: None <nakayosh@kcn.or.jp>
List: netbsd-bugs
Date: 06/27/1997 23:22:09
>Number:         3801
>Category:       misc
>Synopsis:       some documents are installed as executable
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    misc-bug-people (Misc Bug People)
>State:          open
>Class:          doc-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Jun 27 07:35:00 1997
>Last-Modified:
>Originator:     NAKAJIMA Yoshihiro
>Organization:
>Release:        NetBSD-current 1997/06/26
>Environment:
System: NetBSD asura 1.2G NetBSD 1.2G (ASURA) #4: Fri Jun 27 21:55:05 JST 1997 nakayosh@asura:/usr/src/sys/arch/i386/compile/ASURA i386


>Description:
	Some documents are installed as executable, such as:

: install -c -o bin -g bin -m 555 0.t  /usr/share/doc/psd/05.sysman/0.t

	In `bsd.doc.mk', there are the following description:

: BINGRP?=        bin
: BINOWN?=        bin
: BINMODE?=       444

	These are invalid, because these variables are pre-defined in
	`bsd.own.mk'.

	To fix these bugs is one solution, but I think that to use DOC*
	defined in 'bsd.own.mk' is better.

>How-To-Repeat:
	cd /usr/src/share/doc/psd/05.sysman; make -n install

>Fix:
diff -u bsd.doc.mk.orig bsd.doc.mk
--- bsd.doc.mk.orig	Sat May 10 00:14:34 1997
+++ bsd.doc.mk	Fri Jun 27 22:22:27 1997
@@ -19,11 +19,6 @@
 SOELIM?=	soelim
 TBL?=		tbl
 
-BINDIR?=	/usr/share/doc
-BINGRP?=	bin
-BINOWN?=	bin
-BINMODE?=	444
-
 .if !target(all)
 all: paper.ps
 .endif
@@ -44,17 +39,17 @@
 .if !defined(NODOC)
 FILES?=	${SRCS}
 .for F in ${FILES} ${EXTRA} Makefile
-docinstall:: ${DESTDIR}${BINDIR}/${DIR}/${F}
+docinstall:: ${DESTDIR}${DOCDIR}/${DIR}/${F}
 .if !defined(UPDATE)
-.PHONY: ${DESTDIR}${BINDIR}/${DIR}/${F}
+.PHONY: ${DESTDIR}${DOCDIR}/${DIR}/${F}
 .endif
 .if !defined(BUILD)
-${DESTDIR}${BINDIR}/${DIR}/${F}: .MADE
+${DESTDIR}${DOCDIR}/${DIR}/${F}: .MADE
 .endif
 
-.PRECIOUS: ${DESTDIR}${BINDIR}/${DIR}/${F}
-${DESTDIR}${BINDIR}/${DIR}/${F}: ${F}
-	${INSTALL} -c -o ${BINOWN} -g ${BINGRP} -m ${BINMODE} ${.ALLSRC} \
+.PRECIOUS: ${DESTDIR}${DOCDIR}/${DIR}/${F}
+${DESTDIR}${DOCDIR}/${DIR}/${F}: ${F}
+	${INSTALL} -c -o ${DOCOWN} -g ${DOCGRP} -m ${DOCMODE} ${.ALLSRC} \
 		${.TARGET}
 .endfor
 .endif
>Audit-Trail:
>Unformatted: