Subject: misc/2969: uucpd
To: None <gnats-bugs@gnats.netbsd.org, darcy@druid.com>
From: None <darcy@druid.com>
List: netbsd-bugs
Date: 11/26/1996 08:55:59
>Number:         2969
>Category:       misc
>Synopsis:       uucpd
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    misc-bug-people (Misc Bug People)
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Nov 26 06:05:02 1996
>Last-Modified:
>Originator:     D'Arcy J.M. Cain
>Organization:
D'Arcy J.M. Cain                           |  Democracy is three wolves
darcy@{druid.com|vex.net}                  |  and a sheep voting on         
+1 416 943 5281     (DoD#0082)    (eNTP)   |  what's for dinner.
                --  http://www.druid.com/darcy  --                       
>Release:        NetBSD-current
>Environment:
	
System: NetBSD druid.com 1.2B NetBSD 1.2B (DRUID) #0: Sun Nov 24 10:11:21 EST 1996 darcy@druid.com:/usr/src/sys/arch/i386/compile/DRUID i386


>Description:
When using uucp over TCP/IP, the login sequence fails because a newline
and a carriage return are sent and each is interpreted as a newline.
>How-To-Repeat:
Run the UUCP daemon and telnet to the uucp port and try to log in.
>Fix:
*** ../src.original/./libexec/uucpd/uucpd.c	Mon Nov 18 18:01:17 1996
--- ./libexec/uucpd/uucpd.c	Tue Jun 13 06:22:29 1995
***************
*** 211,220 ****
  		if (read(0, &c, 1) <= 0)
  			return(-1);
  		c &= 0177;
! 		if (c == '\n' || c == '\r') {
  			*p = '\0';
  			return(0);
  		}
  		*p++ = c;
  	}
  	return(-1);
--- 211,221 ----
  		if (read(0, &c, 1) <= 0)
  			return(-1);
  		c &= 0177;
! 		if (c == '\r') {
  			*p = '\0';
  			return(0);
  		}
+ 		if (c != '\n')
  			*p++ = c;
  	}
  	return(-1);
>Audit-Trail:
>Unformatted: