>Number:         2814
>Category:       bin
>Synopsis:       Bug in pppd 2.3.0
>Confidential:   yes
>Severity:       non-critical
>Priority:       medium
>Responsible:    bin-bug-people (Utility Bug People)
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Oct  7 03:05:01 1996
>Last-Modified:
>Originator:     Matthias Scheler
>Organization:
Matthias Scheler
tron@lyssa.owl.de
>Release:        1.2
>Environment:
System: NetBSD lyssa 1.2 NetBSD 1.2 (LYSSA) #0: Thu Oct 3 03:44:13 MET DST 1996 tron@lyssa:/usr/src/sys/arch/i386/compile/LYSSA i386


>Description:
If the chat script called by "pppd" fails it tries to deleted the pid file
with an empty filename. As result one gets a log message like this:

Oct  5 02:25:07 colwyn pppd[7280]: unable to delete pid file: Is a directory

>How-To-Repeat:
pppd connect false
tail /var/log/messages

>Fix:
*** main.c.orig	Fri Mar 22 13:32:20 1996
--- main.c	Sat Oct  5 02:30:12 1996
*************** main(argc, argv)
*** 502,508 ****
  	    locked = 0;
  	}
  
! 	if (!demand) {
  	    if (unlink(pidfilename) < 0 && errno != ENOENT) 
  		syslog(LOG_WARNING, "unable to delete pid file: %m");
  	    pidfilename[0] = 0;
--- 502,508 ----
  	    locked = 0;
  	}
  
! 	if (!demand && pidfilename[0]) {
  	    if (unlink(pidfilename) < 0 && errno != ENOENT) 
  		syslog(LOG_WARNING, "unable to delete pid file: %m");
  	    pidfilename[0] = 0;

>Audit-Trail:
>Unformatted: