Subject: Re: port-amiga/1939: grful driver checks for default_mon >= max_mon, but should be >
To: None <netbsd-bugs@NetBSD.ORG>
From: None <is@Beverly.Rhein.DE>
List: netbsd-bugs
Date: 01/16/1996 23:17:28
kjk@sliphost1112.uni-trier.de wrote:

: >Fix:
: Index: grf_ul.c
: ===================================================================
: RCS file: /usr/local/cvsroot/src/sys/arch/amiga/dev/grf_ul.c,v
: retrieving revision 1.1.1.1
: diff -b -c -r1.1.1.1 grf_ul.c
: *** grf_ul.c	1996/01/05 15:11:25	1.1.1.1
: --- grf_ul.c	1996/01/13 18:53:58
: ***************
: *** 471,477 ****
:   #ifdef ULOWELLCONSOLE
:   	if (amiga_realconfig == 0 || ulconunit != cfp->cf_unit) {
:   #endif
: ! 		if ((unsigned)ulowell_default_mon >= ulowell_mon_max)
:   			ulowell_default_mon = 1;
:   
:   		current_mon = ul_monitor_defs + ulowell_default_mon - 1;
: --- 471,477 ----
:   #ifdef ULOWELLCONSOLE
:   	if (amiga_realconfig == 0 || ulconunit != cfp->cf_unit) {
:   #endif
: ! 		if ((unsigned)ulowell_default_mon > ulowell_mon_max)
:   			ulowell_default_mon = 1;
:   
:   		current_mon = ul_monitor_defs + ulowell_default_mon - 1;
: >Audit-Trail:
: >Unformatted:

Approved by the driver author. This is an oversight... the other
mentioned comparison is ok.

Btw, I copied this bug from the retina drivers. It has to be applied
to grf_rh and grf_rt, too, replacing ulowell by retina/rh and ul_ bei
rt_/rh_, as applicable. grf_cl and grf_cv are ok.

	Ignatios Souvatzis