Subject: misc/1725: has strange struct
To: None <gnats-bugs@gnats.netbsd.org>
From: Scott Reynolds <scottr@plexus.com>
List: netbsd-bugs
Date: 11/03/1995 17:39:07
>Number:         1725
>Category:       misc
>Synopsis:       <sys/msg.h> has strange struct
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    misc-bug-people (Misc Bug People)
>State:          open
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Fri Nov  3 19:05:01 1995
>Last-Modified:
>Originator:     
>Organization:
scott reynolds <scottr@edsi.org>
>Release:        01-Nov-1995
>Environment:
	N/A
System: NetBSD beech 1.0A NetBSD 1.0A (GENERIC) #48: Mon Oct 16 14:23:02 PDT 1995 thorpej@basalt:/work/netbsd/src/sys/arch/hp300/compile/GENERIC hp300


>Description:
	<sys/msg.h> defines a "struct mymsg", for which the reasoning is
	clearly stated just before the structure definition.  In common
	practice, however, the majority of systems (both current and
	historical) implement this as a "struct msgbuf" instead.

>How-To-Repeat:
	Examination.

>Fix:
*** include/sys/msg.h	Fri Oct 13 21:56:54 1995
--- msg.h	Fri Nov  3 17:15:00 1995
***************
*** 64,74 ****
   * msgop man page that reads "The structure mymsg is an example of what
   * this user defined buffer might look like, and includes the following
   * members:".  This sentence is followed by two lines equivalent
!  * to the mtype and mtext field declarations below.  It isn't clear
!  * if "mymsg" refers to the naem of the structure type or the name of an
!  * instance of the structure...
   */
! struct mymsg {
  	long	mtype;		/* message type (+ve integer) */
  	char	mtext[1];	/* message body */
  };
--- 64,74 ----
   * msgop man page that reads "The structure mymsg is an example of what
   * this user defined buffer might look like, and includes the following
   * members:".  This sentence is followed by two lines equivalent
!  * to the mtype and mtext field declarations below.
!  *
!  * Common practice in contemporary systems is to use 'struct msgbuf'.
   */
! struct msgbuf {
  	long	mtype;		/* message type (+ve integer) */
  	char	mtext[1];	/* message body */
  };
>Audit-Trail:
>Unformatted: