>Number:         1450
>Category:       port-i386
>Synopsis:       kernel with PCVT pretty screen saver doesn't compile.
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    gnats-admin (GNATS administrator)
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Sep 11 21:20:10 1995
>Last-Modified:
>Originator:     Simon Burge
>Organization:
	Telstra, Australia.
>Release:        sup 9th August 1995.
>Environment:
System: NetBSD dodo 1.0A NetBSD 1.0A (DODO) #4: Sun Sep 10 18:38:41 GMT 1995 simonb@dodo:/slab/0/src/sys/arch/i386/compile/DODO i386


>Description:
	A kernel will not compile if the pcvt pretty screen saver is
	enabled.  The scrnsv_blink() function passed to timeout() has
	an incompatible declaration.
>How-To-Repeat:
	Configure a kernel with pcvt and enable the pretty screen
	saver with an "options PCVT_PRETTYSCRNS" line.  Run "config"
	then "make", and watch it bomb.
>Fix:
	Here's a patch to fix the problem.

*** /sys/arch/i386/isa/pcvt/pcvt_sup.c.ORIG	Fri Jun  2 10:03:00 1995
--- /sys/arch/i386/isa/pcvt/pcvt_sup.c	Sun Sep 10 18:37:25 1995
***************
*** 127,133 ****
  
  #if PCVT_PRETTYSCRNS
  static u_short *scrnsv_current = (u_short *)0;	/* attention char ptr */
! static void scrnsv_blink ( void );
  static u_short getrand ( void );
  #endif /* PCVT_PRETTYSCRNS */
  
--- 127,133 ----
  
  #if PCVT_PRETTYSCRNS
  static u_short *scrnsv_current = (u_short *)0;	/* attention char ptr */
! static void scrnsv_blink ( void * );
  static u_short getrand ( void );
  #endif /* PCVT_PRETTYSCRNS */
  
***************
*** 1965,1971 ****
   *	produce "nice" screensaving ....
   *---------------------------------------------------------------------------*/
  static void
! scrnsv_blink(void)
  {
  	static struct rgb blink_rgb[8] =
  	{
--- 1965,1971 ----
   *	produce "nice" screensaving ....
   *---------------------------------------------------------------------------*/
  static void
! scrnsv_blink(void *arg)
  {
  	static struct rgb blink_rgb[8] =
  	{
>Audit-Trail:
>Unformatted: