Subject: kern/1218: /sys/netiso/tuba_usrreq.c fails to compile
To: None <gnats-admin@sun-lamp.pc.cs.cmu.edu>
From: Alistair G. Crooks <agc@uts.amdahl.com>
List: netbsd-bugs
Date: 07/12/1995 05:05:05
>Number: 1218
>Category: kern
>Synopsis: /sys/netiso/tuba_usrreq.c failes to compile after CIRCLEQ chgs
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: kern-bug-people (Kernel Bug People)
>State: open
>Class: sw-bug
>Submitter-Id: net
>Arrival-Date: Wed Jul 12 05:05:01 1995
>Originator: Alistair G. Crooks
>Organization:
Amdahl Corporation
>Release: July 8th sources, but it's been around for longer.
>Environment:
NetBSD/i386 1.0A, July 8th sources
System: NetBSD rumpy.osg.uk.amdahl.com 1.0A NetBSD 1.0A (RUMPY) #0: Mon Jul 10 11:41:50 BST 1995 root@rumpy.osg.uk.amdahl.com:/usr/src/sys/arch/i386/compile/RUMPY i386
>Description:
compile a kernel with "options ISO". Compilation will fail
in /sys/netiso/tuba_usrreq.c. It looks like this file is a
hangover from the LIST to CIRCLEQ changes, and was missed.
>How-To-Repeat:
see above
>Fix:
*** /usr/src/sys/netiso/tuba_usrreq.c 1995/07/10 09:46:08 1.1
--- /usr/src/sys/netiso/tuba_usrreq.c 1995/07/10 10:47:41
***************
*** 136,143 ****
iso_pcbdetach(isop);
} else {
inp = sotoinpcb(so);
! LIST_REMOVE(inp, inp_list);
! LIST_INSERT_HEAD(&tuba_inpcb.inpt_list, inp, inp_list);
inp->inp_table = &tuba_inpcb;
tp = intotcpcb(inp);
if (tp == 0)
--- 136,143 ----
iso_pcbdetach(isop);
} else {
inp = sotoinpcb(so);
! CIRCLEQ_REMOVE(&inp->inp_table->inpt_queue, inp, inp_queue);
! CIRCLEQ_INSERT_HEAD(&tuba_inpcb.inpt_queue, inp, inp_queue);
inp->inp_table = &tuba_inpcb;
tp = intotcpcb(inp);
if (tp == 0)
>Audit-Trail:
>Unformatted: